Indicate to Mod Menu that Kotlin is a library
matthew-cline opened this issue ยท 16 comments
The latest version of Mod Menu (Fabric allows a mod to indicate that the mod is a library for other mods, so that libraries can be hidden from the list of mods. The Kotlin mod should use this, since right now it shows up 4 to 5 times in the mod list.
Yeah, since the modmenu:api
marker was removed, the included Kotlin libraries are properly marked now and FLK itself isn't.
Why is is being shown 5 times?! Loader is supposed to only load the latest version.
But it's still supposed to only load one... Unless modmenu gets the information in a way that doesn't correspond to what mods are actually loaded.
FLK is marked as a library already, but the JIJ'd submodules aren't (their mod metadata is generated during the build process).
fabric-language-kotlin/src/main/resources/fabric.mod.json
Lines 21 to 23 in bd38e8b
This should be handled in mod menu untill there is a none modmenu specfic way of doing this.
Just make a custom value called fabric:library
or whatever that doesn't have that modmenu namespace?
The problem is that those libraries have fabric.mod.jsons generated by Loom, so currently there's no way to set modmenu:api
/fabric:library
/whatever there.
The JiJ process can just automatically include a fabric:jij
flag in the automatically generated fabric.mod.json.
If a jar already has one, I don't think the build script should be removing/changing them though. :/
Also maybe modmenu needs to change its behaviour so that any jij jars found inside a mod marked as a library are hidden as well.
i did not want to modify the jars pulled from maven, as this is a bunch of extra effort on buildscript (thats complicated enough already), do we really need to do this ?
can this be defined externally in a simple way ?
There's no real way to determine what mod used to be JIJ'd because they're all loaded the same