Fabric Language Kotlin

Fabric Language Kotlin

32M Downloads

Indicate to Mod Menu that Kotlin is a library

matthew-cline opened this issue ยท 16 comments

commented

The latest version of Mod Menu (Fabric allows a mod to indicate that the mod is a library for other mods, so that libraries can be hidden from the list of mods. The Kotlin mod should use this, since right now it shows up 4 to 5 times in the mod list.

commented

Yeah, since the modmenu:api marker was removed, the included Kotlin libraries are properly marked now and FLK itself isn't.

commented

This issue is again present on (at least) v1.7.0.

commented

I think it shows the JIJ'd Kotlin libraries as separate mods.

commented

Why is is being shown 5 times?! Loader is supposed to only load the latest version.

commented

But it's still supposed to only load one... Unless modmenu gets the information in a way that doesn't correspond to what mods are actually loaded.

commented

FLK is marked as a library already, but the JIJ'd submodules aren't (their mod metadata is generated during the build process).

"custom": {
"modmenu:api": true
}

jars-in-jar

commented

This should be handled in mod menu untill there is a none modmenu specfic way of doing this.

commented

Just make a custom value called fabric:library or whatever that doesn't have that modmenu namespace?

commented

The problem is that those libraries have fabric.mod.jsons generated by Loom, so currently there's no way to set modmenu:api/fabric:library/whatever there.

commented

The JiJ process can just automatically include a fabric:jij flag in the automatically generated fabric.mod.json.

If a jar already has one, I don't think the build script should be removing/changing them though. :/

commented

Also maybe modmenu needs to change its behaviour so that any jij jars found inside a mod marked as a library are hidden as well.

commented

i did not want to modify the jars pulled from maven, as this is a bunch of extra effort on buildscript (thats complicated enough already), do we really need to do this ?
can this be defined externally in a simple way ?

commented

Doesn't loom already add the fabric.mod.json by including non-mods?

commented

There's no real way to determine what mod used to be JIJ'd because they're all loaded the same

commented

Let's close this issue as it is no longer relevant

commented

This has been resolved I believe