Bundle FabricASM & Remove dependency on midnight lib
IMB11 opened this issue · 6 comments
Fabric-Shield-Lib should not have a configuration screen, or even require 3rd party library to manage configuration, a TOML file or simple JSON file should do.
Fabric ASM should be jar-in-jar'd as well.
Why not? We offer a config screen so users can adjust simple shield mechanics (enchanting & disabling relationships) to their gameplay style.
It's a library to add new shields, not a "Shield Tweaks" mod. The library doesn't even provide an API to create shield-specific enchantments anymore anyways.
Why should users be allowed to tell the API to start ignoring the mods using it? It's incredibly bad.
IMO the entire config should be out of scope here, the API exists to allow developers to add new shields, not allow users to configure how shields work in their worlds.
The purpose of our configuration screen is to provide an outlet for features where we felt it was not up to us to decide.
Enchating: I was referring to "vanillashieldenchantablity" which allows modders/users to set how(if at all) enchantable the default shield was, as we were able to do so, but saw it unfair to decide that for ourselves, leaving it up to users.
Universal Disable: We left this up to the users again because we had the ability to implement item-only shield disabling or all-shield disabling, and again, we felt it was not our place to decide with system to implement.
I could see maybe implementing some way for modders/modpack makers to lock specific configurations so that users can't change them, but I don't know if such feature exists in ModMenu or MidnightLib