Fabric Shield Lib

Fabric Shield Lib

3M Downloads

Dont include tests in main mod.

IMB11 opened this issue ยท 3 comments

commented

Having a data generator entrypoint in the library mod will break datagen for other mods. It's just bad practice to include test stuff with the library itself as well.

See FabricMC/fabric#4330

commented
commented

Yeah this has caused issues for us in the past, one which I am currently trying to fix: the test enchantment showing up in the release. Before the shift to data, we used to be able to sweep it under the rug with a if(devEnviroment) check.

I will do this in a PR for you in the coming days.

That would be really helpful, thanks! I looked into that myself, but wasnt sure of the exact implementation within the project.

commented

I will push a bandaid fix for said enchant issue to release the 1.21.3 port, but if you make a PR, please do it to the 1.21.3 branch.