
Dont include tests in main mod.
IMB11 opened this issue ยท 3 comments
Having a data generator entrypoint in the library mod will break datagen for other mods. It's just bad practice to include test stuff with the library itself as well.
https://github.com/StellarWind22/Fabric-Shield-Lib/blob/main/src/main/java/com/github/crimsondawn45/fabricshieldlib/initializers/FabricShieldLib.java#L91 All of this should be in a test mod. I will do this in a PR for you in the coming days.
Yeah this has caused issues for us in the past, one which I am currently trying to fix: the test enchantment showing up in the release. Before the shift to data, we used to be able to sweep it under the rug with a if(devEnviroment) check.
I will do this in a PR for you in the coming days.
That would be really helpful, thanks! I looked into that myself, but wasnt sure of the exact implementation within the project.