Add ItemStack context to `getCoolDownTicks` in shield item class

Question

Add ItemStack context to `getCoolDownTicks` in shield item class

IMB11 opened this issue 3 months ago · 3 comments

Would be useful for enchantments that affect cooldown ticks.

IMB11 · Answer 1 · 2025-01-03T16:22:50.000Z

Example:

@Override
    public int getCoolDownTicks(@Nullable ItemStack itemStack) {

        if (itemStack != null) {
            ... = itemStack.getEnchantments().getLevel(...);

            return super.getCoolDownTicks() * ...;
        }

        return super.getCoolDownTicks();
    }
    ```

CringeStar · Answer 2 · 2025-01-03T20:14:04.000Z

Yeah, looks good!
So I just need to change this line to public int getCoolDownTicks(@Nullable ItemStack itemStack) {?

CringeStar · Answer 3 · 2025-01-20T05:41:45.000Z

Done in 1.21.3 and 1.21.4 versions, not sure how far we'll backport.

Share to