Fabric Shield Lib

Fabric Shield Lib

3M Downloads

Mod includes test shield and enchantment

Draylar opened this issue ยท 3 comments

commented

https://github.com/CrimsonDawn45/Fabric-Shield-Lib/blob/ff33251e1104a547807efdbdd3a5595642104a03/src/main/java/me/crimsondawn45/fabricshieldlib/FabricShieldLib.java#L30-L33

Unless I'm missing something or looking at the wrong branch, Fabric Shield Lib is shipping a test shield, test enchantment, and test event in and outside development environments. These calls should be wrapped in a FabricLoader.getInstance().isDevelopmentEnvironment() call so they are not registered in production (= outside an IDE, when users play the game).

image

commented

I considered doing this but I decided against it to mitigate possible client server desync

commented

The issue is dev env vs. production env, not client vs. server. Prod clients do not connect to dev servers.

commented

I realize that but I was unsure how accurate the detection was between dev and prod environment.