Fabric Shield Lib

Fabric Shield Lib

3M Downloads

Shield disabling still applies damage.

ExDrill opened this issue ยท 4 comments

commented

There's an inconsistency with vanilla found in this library. Blocking a hit that disables your shield will still apply the damage. In vanilla, this is not supposed to happen.

commented

I didn't realize that behavior was inconsistent with vanilla this will hopefully be fixed soon I just wanted to push what we had working currently out bc it's been so long lol.

commented

That did infact, fix the issue! I swapped out "HEAD" for "TAIL" and the bug is gone. Will make a PR in a second.

commented

The mixin could probably be injected after the damageShield method is called instead of the head as well. If done that way, at that point the mixin would just be simplified to just invoking the event.

commented

I have found the problematic file.LivingEntityMixin.javais the file causing this bug. Either the mixin itself is unnecessary, or there is a problematic line of code in it.