Fabric Waystones

Fabric Waystones

16M Downloads

[Bug]: Crash when showing unnamed waystone in journeymap

Nemo157 opened this issue ยท 0 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Description

When enabling waystone display with an unnamed waystone the client crashes.

On the server I initially encountered this on I don't actually see an unnamed one in the list when I interact with a waystone; while when I reproduced it in single-player I do see a blank line appear for the unnamed one.

To Reproduce

  • Place a waystone
  • Edit the waystone and clear the name
  • Open the map
  • Click "show waystones"

Expected behavior

Showing waystones doesn't crash

Mod Version

v2.5.0

Minecraft Version

1.18.2

Java Version

Java 17

Fabric Version

  • Fabric: 0.14.10
  • Fabric API: 0.59.1+1.18.2
  • journeymap-fabric: 5.9.0beta3
  • waystones: 2.5.5+mc1.18.2 (not available in the mod version selection......)

Relevant log output

java.lang.IllegalArgumentException: name may not be blank
  at journeymap.client.api.model.WaypointBase.setName(WaypointBase.java:113)
  at journeymap.client.api.model.WaypointBase.<init>(WaypointBase.java:78)
  at journeymap.client.api.display.Waypoint.<init>(Waypoint.java:103)
  at wraith.waystones.integration.journeymap.JourneymapPlugin.addWaypoint(JourneymapPlugin.java:174)
  at java.base/java.lang.Iterable.forEach(Iterable.java:75)
  at wraith.waystones.integration.journeymap.JourneymapPlugin.updateWaypointDisplay(JourneymapPlugin.java:120)

Anything else?

No response