Fabric Waystones

Fabric Waystones

16M Downloads

[Bug]: 2 tabs in Inventory tabs for the waystone

allanonmage opened this issue ยท 0 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Description

Inventory tabs works by giving an additional tab for each item that can be interacted with. Chests, barrels, workstations, etc. The waystones wind up with 2 such tabs, and they appear to be duplicates of each other. Coupled with the other rendering bugs (#192), it seems the two mods trip on each other in several different ways.

  1. Gear icon rendering bug as reported in the other bug report.
  2. Dual inventory tabs as outlined above.
  3. When in the settings mode, there is bleed through to other tabs.
  4. When in settings mode, the gear icon over visually overlaps other chests tabs, but the Z order is messed up, and the other tab takes the click, not the gear icon.

wraith-waystones-3.0.7+mc1.19.2.jar
inventorytabs-0.8.1-1.19.x.jar
fabric-server-mc.1.19.2-loader.0.14.19-launcher.0.11.2.jar

https://www.curseforge.com/minecraft/mc-mods/inventory-tabs

To Reproduce

Install the other mod, to go a waystone, and you will see all the problems.

wraith-waystones-3.0.7+mc1.19.2.jar
inventorytabs-0.8.1-1.19.x.jar
fabric-server-mc.1.19.2-loader.0.14.19-launcher.0.11.2.jar

Expected behavior

The UI should not trip on itself, nor should UI elements stack on top of each other. Not sure how it works on the backend (technically the front end of the code, but from a user perspective all code is backend), so I can't give too much guidance on what to fix.

Mod Version

v3.0.7 or newer

Minecraft Version

1.19.2

Java Version

Java 17

Fabric Version

fabric-server-mc.1.19.2-loader.0.14.19-launcher.0.11.2.jar
fabric-api-0.76.0+1.19.2.jar

Relevant log output

No response

Anything else?

You can see the overlap of the gear icon with the dual waystone tabs. Often times, the gear icon is 98% obsfucated by the right most waystone tab. I think something happened when taking the screenshot to move it just for the screenshot.

2023-04-23_11 06 06

This would actually work great as a feature. I'm not sure what happened, I don't recall seeing that in-game, it could be an artifact of the screenshot process? I'm not sure how to re-create the gear icon above the inventory tabs, but that's a good temporary solution.
2023-04-23_11 06 13

Not only are there 2 inventory tabs for 1 waystone, but you can see that the inventory tabs and the parts of the waystone GUI trip over each other.
2023-04-23_11 05 51

This is an example of switching to another shulker box within the inventory tabs.
2023-04-23_11 05 59