Fabric Waystones

Fabric Waystones

16M Downloads

Feature Request: Allow Removal of Waystones from a players list

fretboardfreak opened this issue · 3 comments

commented

Hi LordDeatHunter,

I've been enjoying the mod so far. It's very nice to have this functionality for Fabric.

I have found however, that if I activate a Waystone and then later break the block it will still appear in the list of targets and will allow me to teleport to the location the Waystone used to be. It does not appear that there is a way for a player to remove unwanted or non-existent waystones from their list at this time.

I see a couple of possible ways to allow something like this:

  • could provide a button or key combo in the UI to let the player manually clean up entries they do not want in the waystone list. This might by handy in case a person wants to remove a Waystone from their own list without breaking the actual block.
  • could try to remove a waystone from all player lists when the block is broken. This might present challenges for example with players on servers that are logged off. I don't know.
  • some other fancy solution I hadn't thought of :)

I'm not very familiar with the available APIs otherwise I would offer to help out a bit more.
Thanks for all your efforts. Take care.

fretboardfreak

commented

Done :)
(I pushed the changes to github, but I still haven't posted on CurseForge)

commented
commented

I'm in survival, fabric 1.16.3. I do have fair set of mods in place and have not yet ruled out interaction with another mod.

'[1.16.3]+Magic+Mirror+1.1.jar'
 BetterCaves-fabric-1.16.2-1.0.2.jar
 betterthanmending-1.2.0.jar
 Bookshelf-1.16.3-8.7.20.jar
 BowInfinityFix-1.16.x-fabric-rv9.jar
 carpet-tis-addition-mc1.16.3-1.3.0+build.108.jar
 curioofundying-fabric-1.1.0-1.16.3.jar
 curios-fabric-0.0.8-1.16.3.jar
 curiouselytra-fabric-1.1.0-1.16.3.jar
 curiousshulkerboxes-fabric-1.1.0-1.16.3.jar
 diggusmaximus-1.4.2-1.16.3.jar
 easierenchanting-1.4.0.jar
 EditSign-Fabric-1.16.3-2.1.3.jar
 elytra-recipe-1.0.1.jar
 expandedstorage-5.6.30+1.16.2.jar
 fabric-api-0.24.1+build.412-1.16.jar
 fabric-carpet-1.16.3-1.4.12+v201001.jar
 fabricmod_VoxelMap-1.10.11_for_1.16.3.jar
 GreaterEye-Fabric_1.16.3-1.1.1.jar
 Hwyla-fabric-1.16.2-1.9.23-79.jar
 InventorySorter-1.7.4-1.16.jar
 itemscroller-fabric-1.16.3-0.15.0-dev.20200912.221805.jar
'JRFTL+[1.16.3]-1.1.jar'
 litematica-fabric-1.16.3-0.0.0-dev.20200913.215807.jar
 lithium-fabric-mc1.16.3-0.5.6.jar
 malilib-fabric-1.16.3-0.10.0-dev.21+arne.1.jar
 minihud-fabric-1.16.3-0.19.0-dev.20200912.222204.jar
 okzoomer-4.0.1+1.16.2.jar
 phosphor-fabric-mc1.16.1-0.6.0+build.7.jar
 RoughlyEnoughItems-5.6.2.jar
 shulkerboxtooltip-2.3.1+1.16.3.jar
 sodium-fabric-mc1.16.3-0.1.0.jar
 tweakeroo-fabric-1.16.3-0.10.0-dev.20200913.175041.jar
 vanilladeathchest-1.16.3-1.11.0.7-fabric.jar
 WAWLA-1.16.3-6.0.1.jar
 wraith-silkspawners-1.0.1.jar
 wraith-waystones-1.0.8.jar
 yabm-2.1.0-beta.2+1.16.x.jar

I just did a quick test with only the fabric-api and your Waystones mod and it is working as you describe.
I may try to do some further testing today to see if I can find the mod that was causing the waystones to not be cleaned up.

That said, it would still be a nice feature for the player to be able to choose to remove a waystone from their list even if the waystone remains present in the world. For example, on a server with a handful of players there may be a set of public waystones that everybody uses and then the players might have other waystones that they set up for themselves.

It might be nice to be able to curate the list of waystones presented to the player. For example, it would be nice to be able to sort my Home waystone to the top of the list and I might want to remove a waystone that I use infrequently so that I do not have to scroll past it in the list to find the target that I want. I am perfectly happy having to "rediscover" the waystone in order to add it back to my list.

So I guess this is a feature request to allow the user to sort and/or remove the Waystones presented to them in the UI.