[1.18.2] witchwater decays in barrel!
MSandro opened this issue ยท 11 comments
This is probably caused by the leaking feature. It happens when certain blocks are near the barrel and get converted.
Might be a good idea to remove it in the future. Could also be a bug with it
I saw this bug and though i should try using the stone barrel since it looks like in REI it's not supposed to leak, but I can confirm the same bug mentioned here. No surrounding blocks are actually converting either.
Looks like it's somehow fixable by reloading and replacing barrel. Given I can do it once per load, I assume some variable is stored directly on the block and not in block state or on the entity.
Able to repro on latest commit.
Perhaps it has something to do with not returning here?
https://github.com/LordDeatHunter/FabricaeExNihilo/blob/1.19/src/main/java/wraith/fabricaeexnihilo/modules/barrels/modes/FluidMode.java#L132
latest 1.18 commit seems to work, unless adding a return for fireproof things only fixed it on non fireproof barrels
It only occurs when extracting via bucket or other item. This also affects milk to slime, for some reason, if you destroy the block instead of properly extracting. It then (somehow) switches to item mode with no item in it, and "extracting" does nothing
The issue is that you forget to copy the barrel mode before switching to alchemy mode. Creating a PR soon.
