Fabrication

Fabrication

305k Downloads

[Performance] Taking so much time when launching

SettingDust opened this issue · 4 comments

commented

Many mods are finding the resources from all the packs. The pack from this mod is finding resources from class loader, which is slow.

I think the resource pack should filter the path instead of finding all the path input

The picture below recorded events should be more accuracy

图片
图片

commented

My pack is way too large. There are 500+ jars.
https://modrinth.com/mod/more-profiling is the tool that providing events. Need to enable the profiling options in config file
Mods that scanning the packs like moremcmeta,continuity, polytone and geckolib should increase the load.
The event from the image is Find Resources https://github.com/SettingDust/MoreProfiling/blob/main/src/main/java/settingdust/moreprofiling/mixin/resourceloadevents/findresources/NamespaceResourceManagerMixin.java

commented

tried installing some of the mods mentioned along with your mod.
i didn't have much success getting a 13s runtime (always sub-second). it's probably depended on other mods/settings?
i'd still like todo this at some point, but i doubt i'll get to it without a very clear case where it happens. (at which point it may be easier to just pr, since you appear to know the issue and have it setup)

commented

To clarify, not all 330s are caused by this mod, it's an inverted tree, the time is consumed by all calls
I'll update this issue with a top down tree after a while

commented

sure i'll see if i can look into this before the next release.
Please give me instructions to reproduce and measure it, since you already have a setup.