Fabrication

Fabrication

Mods
350k Downloads

Incompatibility with Embeddium++

CraftyZombie opened this issue · 8 comments

commented

Minecraft 1.20.1
Forge 47.3.12

Mods List:
Embeddium 0.3.31
Embeddium++ 1.2.13
Forgery 3.5.1

When Forgery is installed with Embeddium++ (https://www.curseforge.com/minecraft/mc-mods/embeddiumplus), several issues occur.

  1. The config file of Embeddium++ is ignored and overridden with default values.
  2. Trying to apply settings after modifying an Embeddium++ option crashes the game.
  3. Nether fog becomes a neon green/yellow hue.
  4. Lava becomes entirely transparent when submerged.

Because of the diversity of these issues, there might be more problems, but those are the ones that I discovered.

Crash and Logs: https://gist.github.com/CraftyZombie/2e70019bf67dd41c1575f5670c8f1980
Screenshots: https://imgur.com/a/5UqZvYC

commented

Sorry, I didn't consider that my config for Forgery is modified.
https://gist.github.com/CraftyZombie/aaec8a02326b86025b3158acce9f7abb

commented

Embeddium++ has a very explicit logger about loading config and any of your logs has any log output from Embeddium++, the only reason of why it isn't loading is

  1. Forgery somehow makes Embeddium++ config spec think "its loaded" when it isn't
  2. Forgery changed the forge environment dist

nvm, seems like is not an isolated issue caused by forgery, someting is causing config not load

commented

Please figure out what features specifically are in conflict

commented

thats not an "improper" place, configuration its completly independant from modloader usages.
That little hack early-loads configuration when any mixin requires it early, because if i await for common setup it causes crashes when its attempted to use config fields.

and no, await for loading to update the config only induces weird window size switching, which its not ideal

commented
commented

Found it. Sorry for the wait.
https://gist.github.com/CraftyZombie/8e6b87a6535e2f9ae1affc68f2d27e75

It's the "No Set Window Position" Experiment.

commented

@SrRapero720
https://github.com/SrRapero720/EmbeddiumPlus/blob/1.20.1/src/main/java/me/srrapero720/embeddiumplus/mixins/impl/borderless/BorderlessWindowMixin.java#L14C1-L14C55

the config is being loaded from an improper place.

load the config from a reasonable place, like game startup.