Fabrication

Fabrication

350k Downloads

Mixin conflict with "Too Fast"

MylesGit opened this issue · 5 comments

commented

Fabrication has a mixin conflict with the mod "Too Fast".

See log here: https://gist.github.com/MylesGit/ce8e6ea26e244b9763ff86192211c0f1

commented

Fabrication provides the same functionality under Unsafe → Disable Moved Too Quickly. Set that feature to banned or turn off runtime_checks if you need to use the other mod for some reason.

Not sure why this conflict isn't triggering failsoft and just disabling the feature in Fabrication.

commented

Not sure why this conflict isn't triggering failsoft and just disabling the feature in Fabrication.

This was the reason I made the issue. Found it odd Fabrication didn't automatically disable that Mixin. I already removed the opposing mod, just thought I would inform you guys regarding the issue.

commented

while yes failsoft should protect against crashing on a fabrication injection.
it never protected against crashing on other mods injections.
this would probably not crash if fabrications just happens to inject after.

pretty much every mod that does this seems to be doing the exact same thing with slightly diffrent semantics.

now here's the real question is why the hell does mixin choose to consider ModifyConstant conflicting injections?? the semantic for it should be perfectly fine to stack.

commented

pretty much every mod that does this seems to be doing the exact same thing with slightly diffrent semantics.

ye there's a better way to do this injection at least in 1.21, will check the other versions and redo it.
i'll try and remove modify constant from fabrication, considering i now know it behaves like this

commented

ye i didn't compleatly remove ModifyConstant. some are a pain too, soo i'm not unless required.
the one that caused this is gone though