FabricTailor

FabricTailor

327k Downloads

[BUG] Wrong Skin & GUI become blue

barraIhsan opened this issue · 5 comments

commented

Describe the bug
So first when i set for example Dream skin it would look like this
image
It supposed to be not like that, it should look like this
Second, when I select a text the gui will turn become blue
image

To Reproduce
Steps to reproduce the first bug:

  1. Type /skin set player Dream or open GUI (by default k), type Dream and click Set Skin

Steps to reproduce the second bug:

  1. Open GUI (by default k)
  2. Type anything
  3. Select a text

Logs
Doesnt result any error in logs

**Are you using any other mods?
Yes, this is the list
image

commented

The wrong skin is the fault of the ely.by skin proxying ...
No idea about the blue GUI though 🤔

commented

I think its because copying the color of selecting to a gui? idk

commented

Lol, that could be the case ... it's still weird :D

commented

The wrong skin is the fault of the ely.by skin proxying ...

Wouldn't it be possible to do it differently?
Impersonate used to have wrong skins like FabricTailor but was fixed in this commit:
Ladysnake/Impersonate@8bcf7c0
Would it be possible to change FabricTailor to the same skin proxy/source?
Maybe a modified version of https://github.com/Ladysnake/Impersonate/tree/master/src/main/java/io/github/ladysnake/impersonate/impl/ServerPlayerSkins.java could work as that is a modified version of your code (https://github.com/samolego/FabricTailor/blob/1.0.0/src/main/java/org/samo_lego/fabrictailor/FabricTailor.java)

I know nothing about Java though so I might have just been writing complete gibberish. Sorry if that is the case.

commented

Since working on this, I found some better methods, but rn I'm a bit busy with other things ...