Fairy Lights

Fairy Lights

34M Downloads

Unable to produce pattern in lights (Valhelsia 1.16.5)

fightmesun opened this issue ยท 5 comments

commented

when crafting multiple colours, the outcome will only take the first light. So if I make a pattern of red, black, purple; only a string of red lights will be crafted

commented

Issue has been fixed on FastWorkbench's side.

commented

Thanks for reporting!

Could you provide a screenshot?

commented

I've also experienced this issue, and I believe it to be related to mods such as FastWorkbench (I think that's its name) that change how crafting recipes are handled.
A short term fix is to take one of the vital ingredients (iron or string) out and put it back in, the recipe will temporarily become invalid when you do it and then when you put it back, it will re-look up the recipe and see the other ingredients, and update the output accordingly.

commented

Shadows-of-Fire/FastWorkbench#72 (comment)

as per the fix for Shadows-of-Fire/FastWorkbench#58 c2a1a64, FB now always pushes a stack update every time the input changes if either the recipe changes, or the recipe is dynamic. Given that this recipe does this, it sounds like it's not properly returning true to IRecipe#isDynamic?

It looks like, for example, the hanging lights recipe, creates a dynamic recipe with an output:

return new GenericRecipeBuilder(name, HANGING_LIGHTS, FLItems.HANGING_LIGHTS.get())

Which causes isDynamic to return false:

public boolean isDynamic() {
return this.output.isEmpty();
}

commented

Yes this correct, I have recipes which isDynamic() returns false, as they implement getIngredients() for an example recipe so the recipe book is capable of displaying them. It looks like FastWorkbench is constructing its own exceptions of the semantics of the method. Nothing I can do I my end.