FallingTree

FallingTree

40M Downloads

preserve tools not working when "damageMultiplicand" > 1.0

scarf005 opened this issue · 6 comments

commented

Describe the bug

[Preserve tools] This controls how the mod behaves when a tree is cut with a tool that is going to break.
No: The tool will be fully used and broken.
Yes: The tool won’t be fully used and be left with 1 of durability.

however tools with durability 1 would

  • not break any blocks
  • refuse to get broken
  • with message from "chat.fallingtree.prevented_break_tool".

regardless of how the configuration above is set.

Minecraft version

1.18.1

Fabric API version

0.46.1

Mod version

3.2.0b1

Relevant log output

Your tool is about to break, go repair it or get a new one.
commented

the exact opposite. i was expecting the tool to break when its durability is 1, but it doesn't. i cannot destroy my tool, the mod would just send "chat.fallingtree.prevented_break_tool" and refuse to break the tool. despite preserve tool config set to no.

commented

I cannot reproduce.

javaw_2022-01-24.19.15.12.626_ZHYxcNw1VP.mp4
  • If you play with other mods, can you reproduce the behavior with FallingTree alone?
  • Do you plan on server ? If so this is the server config that is taken into account.
  • Can you share your fallingtree.json content?
commented

to reproduce the issue, change "damageMultiplicand" to any value bigger than 1.0. for example

  • issue happens on: 1.2, 1.5, 2.0.
  • issue does not happen on 1.0, 0.7, 0.5

here's the configuration: fallingtree.json.txt

commented

I don't have the time to test it right now, but I made changes where I think the issue is. If you wanna test it before you can grab the modified version here (artifacts at the bottom).

commented

This one should behave a bit better I think.
The one mentioned above was probably breaking several blocks even though only one should have been broken.

commented

I'm not really getting what's the issue here.

When you have 1 of durability the tool breaks and you expect it not to break?