FallingTree

FallingTree

Mods
28M Downloads

Some config parameters doesn't work

Disketaa opened this issue · 2 comments

commented

Describe the bug

Greetings! I found that some of the config parameters doesn't change anything at all.
Here's the config:

{
  "trees": {
    "allowedLogs": [],
    "deniedLogs": [],
    "allowedLeaves": [],
    "allowedNonDecayLeaves": [],
    "deniedLeaves": [],
    "breakMode": "INSTANTANEOUS",
    "detectionMode": "ABOVE_CUT",
    "maxScanSize": 500,
    "maxSize": 50,
    "maxSizeAction": "CUT",
    "breakOrder": "CLOSEST_FIRST",
    "minimumLeavesAroundRequired": 1,
    "includePersistentLeavesInRequiredCount": true,
    "treeBreaking": true,
    "leavesBreaking": true,
    "leavesBreakingForceRadius": 0,
    "allowMixedLogs": false,
    "breakNetherTreeWarts": true,
    "instantlyBreakWarts": false,
    "breakMangroveRoots": true,
    "searchAreaRadius": -1,
    "allowedAdjacentBlocks": [],
    "adjacentStopMode": "STOP_ALL"
  },
  "tools": {
    "allowed": [],
    "denied": [],
    "preserve": false,
    "ignoreTools": false,
    "damageMultiplicand": 1.25,
    "damageRounding": "ROUND_DOWN",
    "speedMultiplicand": 0.75,
    "forceToolUsage": false
  },
  "player": {
    "allowedTags": []
  },
  "enchantment": {
    "registerEnchant": false,
    "registerSpecificEnchant": false,
    "hideEnchant": false
  },
  "sneakMode": "IGNORE",
  "breakInCreative": false,
  "lootInCreative": true,
  "notificationMode": "NONE"
}

  1. Tools are getting saved on 1 durability point even if the value sets to false.
    13

  2. Mangrove roots doesn't destroys
    14

  3. Break nether leaves with one hit doesn't affect anything (or I don't get it) plus some of warts keep floating in the air
    15

Here's my modlist, I didn't check the issue with blank MC and only Falling Tree mod cause I'm not sure that'll change anything
image

Minecraft version

1.20

Fabric API version

0.85.0

Mod version

4.2.1

Relevant log output

No response

commented

Thanks for the explanation <3

commented
  1. This is actually the case because of the damage multiplicand.
    From my testing, I have an axe with 4 burability and the 1.25 multiplicand. It means that I'm allowed to break 4/1.25 = 3.2 blocks. So it'll break max 3 blocks.
    This will as a result leave a durability of 1. This is this way because otherwise you'd break more blocks than the multiplied durability allows.
  2. You have set Trees > Detection Mode = above cut. As the roots are below the log that is cut, it isn't taken into account.
  3. The "break warts" will break the warts (leaves) as you saw. Though you have a max tree size of 50 defined so it'll often be more blocks than this and therefore cut only parts of the tree. The "with one hit" variant is only useful with the shift down method. I can probably clarify that in a future release as it's not too urgent.
  • ❤️1