FancyMenu [Fabric] [MOVED TO NEW PROJECT]

FancyMenu [Fabric] [MOVED TO NEW PROJECT]

17M Downloads

broken executeWithCallback function

bluffcon opened this issue ยท 5 comments

commented

fancymenu.executeWithCallback(actionType, actionValue, onSuccess, onFailure)
^ ONFAILURE COMES BEFORE ONSUCCESS

onfailure runs every execution, onsuccess runs only on success from my observations

commented

if youll trust the wiki, onsuccess runs every single execution and onfailure runs on success

commented

I mean I suck at JS, but wouldn't it be best to run onSuccess() only on success and onFailure() only on failure??
This would, in theory, always run one of the two, but never both.

commented

nvm, just made it work like that now lmao

commented

I mean I suck at JS, but wouldn't it be best to run onSuccess() only on success and onFailure() only on failure?? This would, in theory, always run one of the two, but never both.

https://cdn.discordapp.com/attachments/733066398879711312/1430202690901639219/image.png

idk what the code was like but this looks like not intended
they SHOULD be doing that as you described. they werent

commented

yes, but they do now, so all fine
(at least they should lmao)