Framerate inconsistency/stuttering with panorama background
HaXrDEV opened this issue ยท 17 comments
Describe the bug
When using a panorama for the background the motion isn't 100% smooth, which appears to be caused by the framerate fluctuating somewhat resulting in stutters. This is also measurable using Fraps. The issue gets progressively worse the more mods are installed which makes the stutters more intense and more frequent.
It is important to mention that when switching off all customization (going back to the vanilla main menu), the motion of the background is perfectly smooth and locked to 60fps.
To Reproduce
Steps to reproduce the behavior:
- Put on a Panorama background
- Notice that the background slightly stutters. (Turning up the speed at which the camera looks around makes it way more obvious.)
Expected behavior
The framerate should not fluctuate at all when in the main menu and the motion of the panorama background should be just as smooth as in the vanilla main menu.
Crash Log
Not a crash and there is no errors in the logs.
Basic Informations
- OS: [Windows 10]
- FancyMenu Version [2.4.3]
- Forge/Fabric Version [36.2.22]
- Minecraft Version [1.16.5]
- Active Mods [FancyMenu, Konkrete]
Additional Information
- Java version [1.8.0.51 (64bit), 1.8.0.291(64bit)]
- Processor [i7-9700K]
- Graphics Card [RTX 2080]
- Graphics Driver: 496.13
I can somewhat add on to this, the framerate in the menus when the menu is customized quite a bit drops the FPS by A LOT.
Monitoring it with fraps as you also mentioned we can see it at 10 fps. When the menus are off i.e vanilla menu. It's stable at 60 fps. Like it should be.. right?..
Here's a vid showing it in action: https://streamable.com/kn02qd
Should mention this is on 1.18, but happens on 1.17 & 1.16 after an update.
On 1.16.5 everything is fine on version 2.2.2-2, after that. FPS tanks. All the way down to 10 fps... This update made fps tank by alot: https://www.curseforge.com/minecraft/mc-mods/fancymenu-forge/files/3467954
This has to be some kind of mod conflict.
It's probably related to one or more of the placeholder text values or the visibility requirements I've added in the update you've mentioned.
Thing is, I've tested the pack from the video and you're right, it drops down to 10FPS when loading the full pack, but has completely stable ~60FPS when only FancyMenu, Drippy Loading Screen and Konkrete is loaded. This means that some of your 300+ mods is causing this. Maybe I can fix it on my end, but I can't check 300 mods for incompatibilities.
I also think that the original issue is not really related to this one.
Could be different ones.
Update:
I was able to narrow it down to placeholders. It has to be one of the placeholders I've added in this one update.
Will try to find the right one and fix it.
Update 2:
It's one of the mod-related placeholders (totalmods, loadedmods, etc.). So not a placeholder I've added in that specific update, but I also changed the behaviour of placeholders. Placeholders get updated a lot more often starting in this update, so it's probably that checking for many mods too often causes the FPS drop. Sooo, well, it could be related to the original issue.
This also means that it's not a mod conflict.
Update 3:
Fixed. The fix will be part of the next update! :)
Awesome news!
Late reply, had some stuff do to.
Fixed. The fix will be part of the next update! :)
Can't wait. ๐
Fixed in FancyMenu v2.5.0! Thank you both for your reports! :)
So I updated, still getting 10 frames in the menus.. hm..
Works fine for me: https://www.youtube.com/watch?v=sTtHlz0wvxs
Did you really use v2.5.0?
Strange the fps doesn't drop for you at all. ๐ค
Is this hardware specific maybe?
Another vid: https://streamable.com/eydm3u
Deleting every clickable link, test and custom buttons made the fps go up to 60fps.
edits:
.. and adding one button with 1 link attached made the fps drop by 15fps
and adding another one, drops it by another 15 fps.
just adding buttons makes the fps drop significantly. even without links attached.
here's another vid me deleting buttons one after another, bringing the fps up:
https://streamable.com/nll0zz
Is this updated pack version already online? Can I download it?
Please show me the FM version number you see in the Mods tab.
Please show me the last button action you see in the Button Action menu of a custom button, when clicking til the last entry of the switcher (right arrow button).
Downloaded 2.5.0 manually instead, and now it works. No more fps drops.
CurseForge Launcher is really wonky tbh, not really that good.
As I thought :D It's a launcher problem then. That's why I always want the version displayed in the actual game, because I know that launchers like to mess up updating to new mod versions :)
Anyways, I'm happy it works now! Thank you again for reporting it!
I just wanted to add that with no other mods installed the framerate consistently fluctuate between 57 and 60 fps. Which may not sound so bad. But it is clearly felt compared to the vanilla main menu.
Though that is a rather subtle issue compared to enabling panorama on a modpack with 200+ mods installed, which makes the framerate drop to a meager 22fps (panorama speed makes no difference).
One thing that is really weird however, is that if you enter editing mode the issue almost completely disappears and just goes back to fluctuating between 57 and 60fps.
If you want to see it for yourself this is where I have the mod deployed: (version: pre5-2.0.0) https://www.curseforge.com/minecraft/modpacks/dynamite2
I can somewhat add on to this, the framerate in the menus when the menu is customized quite a bit drops the FPS by A LOT.
Monitoring it with fraps as you also mentioned we can see it at 10 fps. When the menus are off i.e vanilla menu. It's stable at 60 fps. Like it should be.. right?..
Here's a vid showing it in action:
https://streamable.com/kn02qd
Should mention this is on 1.18, but happens on 1.17 & 1.16 after an update.
On 1.16.5 everything is fine on version 2.2.2-2, after that. FPS tanks. All the way down to 10 fps...
This update made fps tank by alot: https://www.curseforge.com/minecraft/mc-mods/fancymenu-forge/files/3467954