FancyMenu [Fabric] [MOVED TO NEW PROJECT]

FancyMenu [Fabric] [MOVED TO NEW PROJECT]

17M Downloads

[1.19-Forge] Default GUI Scale applies on every launch not just first.

Gbergz opened this issue ยท 23 comments

commented

Describe the bug
The Default GUI Scale config option applies on every launch not just first.

To Reproduce
Steps to reproduce the behavior:

  1. Set to any gui scale in config.
  2. Start game.
  3. Change to another gui scale
  4. Restart
  5. GUI scale reverts again.

Expected behavior
That the GUI Scale stays on the scale I chose.

Crash Log
No crash.

Basic Informations (please complete the following information):

  • OS: Windows
  • FancyMenu Version : 2.7.2-1_MC_1.19
  • Forge/Fabric Version : 41.0.16
  • Minecraft Version : 1.19
  • Active Mods : Only FancyMenu + required libs
commented

Here's the debug of when it happens https://gist.github.com/Gbergz/9da0a8736b454b73da0ee7c33ff828ad

This log shows that it only sets the scale to 4 two times.
That's normal and it never gets set to 3. At least not in MC's config.
What you describe is simply not possible, that's all I can say to this lmao

And I'm very sure it's not a bug caused by FancyMenu.

Pretty sure I do NOT have one of those mods, however I very well could be wrong.

I don't talk about a mod, I talk about a feature of FancyMenu.
You can force a GUI scale for a menu by right-clicking the editor background and clicking on Gui Scale.
This will not change the actual GUI scale of MC, it just renders the menu in a different scale.


tl:dr I think there's something going on in your 1.19 packs/instances and maybe FancyMenu plays a role in it, but I don't think it's a bug in FM.

commented

tl:dr I think there's something going on in your 1.19 packs/instances and maybe FancyMenu plays a role in it, but I don't think it's a bug in FM.

Yeah agreed, I guess making it fullscreen before the pack is done booting up is a workaround for now.
I will try to find a solution.

commented

Will close this for now, but if you manage to find the reason for it (regardless of if it's related to FM or not), please tell me here! :)

commented

This is happening on Fabric as well. I set the default GUI scale to be 3, but it will always set it to 2 instead on the first startup.

commented

Hi you both!

  • Do you have a file called defaultscaleset.fancymenu in .minecraft/mods/fancymenu?
  • Can you send me your .minecraft/logs/latest.log, please?
  • Please send me your .minecraft/config/fancymenu/config.txt file.

Thank you very much!

commented

Do you have a file called defaultscaleset.fancymenu in .minecraft/mods/fancymenu?

Yes. It's empty though.

Can you send me your .minecraft/logs/latest.log, please?

Here you go : [latest.log]

Please send me your .minecraft/config/fancymenu/config.txt file.

Also here you go : [config.txt]

commented

Hmm. Please try it without FancyMenu installed. (Even if you have no other mods installed)

commented

Thank you! I will try to reproduce this, but wasn't lucky yet.

A workaround for this is to set the default scale to -1. This should completely disable the feature.

commented

A workaround for this is to set the default scale to -1. This should completely disable the feature.

That I did try, didn't work either unfortunately. As it was that initially. How I noticed the problem.

commented

That's not really possible o.O Are you sure it's not something different that sets the scale?

commented

Problem solved without FancyMenu

commented

Please also try it multiple times with this new build. So if it happens the first time, send me the log and then try it again to see if it still happens, because I tried to tweak the feature a bit already. Maybe this already fixes the bug, but this potential fix gets applied after the first time FM sets the scale, so you will need to test it at least twice to see if it's fixed now.

commented

Please try it with this build: https://drive.google.com/file/d/17gT0HB1pT9k5Q9nzlQFwZLvd9p5u2otE/view?usp=sharing

..and send me your .minecraft/logs/latest.log file again, after the GUI scale issue happened with this new build.

It's a debug build that prints to the log what exactly sets the GUI scale.

commented

Don't really know what happened, but I quit the game. Changed the setting to 1 in the config file, started the game. It set the gui scale to one, then I changed it back to -1 while ingame. Quit the game. restarted about 10 times now, my gui scale stays the same.. problem just went poof?

hm..

commented

Before reading your comment I tried changing the value to "none". Which disabled the feature for me. Will probably go back and change it to -1 if that is the intended way of disabling it. My issue is probably just related to using an old config file to be honest.

commented

Don't really know what happened, but I quit the game. Changed the setting to 1 in the config file, started the game. It set the gui scale to one, then I changed it back to -1 while ingame. Quit the game. restarted about 10 times now, my gui scale stays the same.. problem just went poof?

hm..

Was this with the new build I sent you?

commented

No it was with the old one, tested with both. Suddenly just gone.
But it comes and goes, though this time in my modpack instance with other mods. Not sure anymore tbh.. :s

commented

Here's a log with the version you sent me
https://gist.github.com/Gbergz/f48f27ef0aa2b49996b0bb025e0d2bc4

though this is with other mods aswell, changes to 3 from 4 when resizing window after the game has booted to main menu.
if you make window fullscreen while booting. it stays on 4.

commented

In normal vanilla or just regular forge install with no mods if you set GUI Scale to 4 for example-
and when booting up you do not change the window size at all, the GUI scale will stay at 4.

But here in modded it will change GUI scale to 3 if it was 4.

But if you maximize the window upon starting up on the mojang logo the GUI scale will stay at 4.

Hard to explain hope you understood.

commented

Here's a log with the version you sent me https://gist.github.com/Gbergz/f48f27ef0aa2b49996b0bb025e0d2bc4

though this is with other mods aswell, changes to 3 from 4 when resizing window after the game has booted to main menu. if you make window fullscreen while booting. it stays on 4.

###################################### SETTING GUI SCALE TO: 4 | FROM:

In the log above, it sets the scale to 4 two times while starting the game, which is absolutely normal. It doesn't set it to 3, at least not in this log. Maybe you forgot to resize the window?

"It changes the scale on resize" sounds more like MC's auto-scaling to me. It does that if the GUI scale is too big for the window size. Did it set the scale to 3 when you were making the window smaller? If so, it's just MC and no mod.

commented

Can you please use the debug version I sent you to get another log of this? Please send the log AFTER you've seen the scale changing from 4 to 3 (this is really important).

Are you sure you don't just have a layout that forces a specific GUI scale for that specific menu?

commented

Here's the debug of when it happens
https://gist.github.com/Gbergz/9da0a8736b454b73da0ee7c33ff828ad

Edit:

Are you sure you don't just have a layout that forces a specific GUI scale for that specific menu?

Pretty sure I do NOT have one of those mods, however I very well could be wrong.

commented

It was caused by Forge and is now fixed. Just wanted to tell you.