FancyMenu [Fabric] [MOVED TO NEW PROJECT]

FancyMenu [Fabric] [MOVED TO NEW PROJECT]

16M Downloads

[1.18] Sound channel doesn't work, volume setting doesnt work

Saereth opened this issue ยท 12 comments

commented

Describe the bug
When I add a new sound element and assign a custom ogg file it plays as expected however when I set the channel to music, the volume controls are still tied to the master volume control. Additionally if I set the volume to 40% in the element it still plays at full volume. This results in a very unpleasant user experience of getting blasted with music until you turn your master volume down.

To Reproduce
Steps to reproduce the behavior:

  1. Add a custom sound element file
  2. Set the channel to music
  3. Set the volume to 40%
  4. volume and channel are ignored

Expected behavior
I would expect the sound to play on the correct audio channel and respect volume settings

Crash Log
N/A

Screenshots
image
image

Basic Informations (please complete the following information):

  • FancyMenu Version [fancymenu_forge_2.8.0_MC_1.18.2]
  • Forge/Fabric Version [40.0.41]
  • Minecraft Version [e.g. 1.18.2]
  • auudio_forge_1.0.3_MC_1.18-1.18.2
commented

They are not resolved, they just happen randomly. I fixed them, the update is just not public yet, because I need to work on it a little more :)

The loading order being the issue was wrong. It's more how many elements FM has to load when open a menu. If loading takes too long, it will kill the audio and restart it.

commented

Both bugs should be fixed in v1.1.1 of the extension (hopefully). Thank you for your report! :)

commented
  • Please try it with only FancyMenu + dependencies installed
  • If step 1 doesn't change anything, please send me your .minecraft/logs/latest.log
commented

Seems the issue with it being on the right audio channel isnt present after I removed/readded the audio file so im not sure what was causing that. The volume setting however still doesn't work.

with only these mods:
image

The volume setting is ignored in the audio file settings. here is the latest.log
latest.log

commented

Can you please send me your setup? You can export your setup via Setup -> Export in the customization menu bar.

commented

Can you please send me your setup? You can export your setup via Setup -> Export in the customization menu bar.

commented
commented

Here is a curseforge export of the test instance. The main menu volume is currently set to 5% but you'll see...
https://drive.google.com/file/d/1U2CuZNeCvW88gpqiCz8zv-FHv_EM2Ahu/view?usp=sharing
This is the current modlist:
image

MC 1.18.2
forge 40.1.52

commented

Thank you for sharing your instance!

Soooo.. you've triggered multiple bugs :'D

  1. The audio channel didn't work because you had the same audio in a universal layout and your main menu layout, which, for some reason, completely broke that audio, so it kept playing even in menus without customizations enabled and it was locked to the MASTER channel. I removed the audio element from the main menu layout, restarted the instance and now everything works as intended (with only the universal layout audio element).

  2. For some reason when going back to the main menu from another menu, the background audio restarts, which shouldn't be the case. This gets fixed when disabling the main menu layout, so something in this layout messes with the audio element. I wasn't able to identify what action/element exactly triggers this, but will keep testing! :)
    //UPDATE: Custom buttons seem to be related to this issue.
    //UPDATE 2: I think custom buttons being the reason was only a side effect. It seems to be related to the order the layouts are loaded.
    //FINAL UPDATE: Loading order being the reason confirmed. When a layout gets loaded after a layout with an audio element in the same menu, it breaks the keep-playing mechanic.

The background music track is absolutely great btw lmao

commented

haha wow thats quite the find, glad it was useful and at least the fix for the volume I can put in immediately so that's great. Thanks a lot!

commented

I've found the reason for the audio restarting bug. Check the updates above! :)
Will try to fix these bugs asap.

commented

With the latest update most of these issues seem to be resolved by going to a universal layout only for the sound except that when you return to the main menu the sound restarts. You can navigate through any sub menus and it keeps playing as expected but anytime you return to the main menu it starts over. I've double checked there is no audio file on the main menu its all coming from the universal template now.