FancyMenu [Fabric] [MOVED TO NEW PROJECT]

FancyMenu [Fabric] [MOVED TO NEW PROJECT]

16M Downloads

Mod compatibility issues due to cancelled super call in TitleScreen#render

DJtheRedstoner opened this issue ยท 0 comments

commented

Starting in 7bb78a0, FancyMenu cancels the super.render call in TitleScreen#render. This causes mods which depend on the super method being called (for example, to send their own events), breaking in various ways. Specifically, this affects Essential, by causing Essential's custom main menu overlay to not render.

Since the goal of cancelling super.render is to prevent fancymenu's events from being posted twice, this could also be achieved other ways, such as setting a boolean flag to suppress the events, or posting the events from a method that gets overridden to a no-op in TitleScreen.