FancyMenu [Fabric] [MOVED TO NEW PROJECT]

FancyMenu [Fabric] [MOVED TO NEW PROJECT]

17M Downloads

Button customization not working in CreateWorldScreen because of invisible overlapping buttons

kreezxil opened this issue · 19 comments

commented

Need the option to turn off Warnings. FM is reporting offhandedly odd button overlaps. A player reported https://pastebin.pl/view/e4666cd8 and when i went to fire up dev copy of the client, i got a totally different set of warnings and it looks like it was complaining about forge buttons overlapping. https://gist.github.com/d6ef99fab07c800de5bb482baf52a537

I checked the menu i created and not one of the visible buttons are overlapping. It's hard to find invisible ones once you hide them.

So yeah, a config feature to turn off that warning would be great.

commented

could you add something helps reveal what mod is placing off screen buttons?

commented

Sadly no. It's nearly impossible to track what mod added objects to menus :/ I can add some more informations to the warning that could MAYBE help to find out which mod it is in some cases, but nothing that works 100% :/

commented

I will add a config option to turn off warnings, but they are fired for a good reason. One of your mods seems to really mess up something and probably tries to add buttons at totally useless coordinates.
At: X=-1418392361 Y=-1418392496!
They are negative too, so no one will ever see them. The button labels aren’t set either, so they would rather be image buttons or just blank buttons without any sense.

commented
commented

Did some digging. created a 1.16.3 pack with just fancy menu it, the previously reported issues of the odd warnings. Well it's still here with just fancy menu and konkrete

https://gist.github.com/56e90f40be9ee7e80711c49cb9fd1ec0

The overlapping buttons warning is come from the Singleplayer world creation screen.

and i think your mod is culprit, i'll show you.

Before

image

After

image

The customize button is not there in the regular view but shows up in the create layout view

For now the kludge is define that button and move it somewhere. Which I'll Do.

commented

oh wow, FM thinks every button on that page is overlapping

commented

ok, i figured it out, when you click more options, the page doesn't change but the buttons do.

image

It's likely a mojang thing. They're cheating, the page has 2 button panels, the one not in use is hidden. FM doesn't realize this and assumes they're over lapping.

The easy solution for me while you render a fix is to move all the buttons on to one page if that is even possible.

commented

so the customize button i saw earlier, wasn't yours but from that second page.

commented

I reported this before and you said the solution was to full screen. I'm full screened and on gui 2, i have context menus going off the screen.

before

image

i know this should be in another ticket, but since i'm doing the current thing with identifying the warnings

after

The buttons in the green zone, their context menus went down and i could access "set orientation"
The buttons in the red zone, their context menus went up and thru the top of the screen and i could not access "set orientation"
image

commented

Need to point out that was full screen windowed. Absolute full screen "borderless" and the context menu is readable and goes down for the red zone.

commented

these are the droids you're looking for

I was able to move the "customization" button because it was revealed, but these others in the red zone, i can't get to. to move them.

image

another log

https://gist.github.com/87d1132cd5282ecf730b154b56f4cfce

commented

make sure this feature also gets pressed to 1.12.2

commented

Everything I add to the mod will be in all versions of it, if possible.

commented

oh wow, FM thinks every button on that page is overlapping

It not just thinks that they are overlapping, they ARE overlapped, but invisible ^^
I have to say, this is by far the most annoying screen ever.
It doesn't open a new screen when clicking on "More World Options", but changes the visibility of the buttons needed for it and makes the previous buttons invisible. The positions of these buttons are the same, that's why they are overlapping.

I will try to fix this.

commented

I added a config option to turn of warnings in FancyMenu v1.6.0 as workaround for the log spam, but will keep try to find a good fix for this screen. But the way this menu is coded makes it nearly impossible to make it compatible with my customization engine.. I would need to override the whole screen to add full support :/ Will keep trying!

commented
commented

What exactly do you mean by "chained buttons"? :D

commented
commented

Can't do anything to fix this, I'm sorry.