Nothing drops loot
Closed this issue ยท 11 comments
Minecraft version
1.21.1
Farmer's Delight version
3.0.0
Fabric Loader version
1.16.10
Fabric API version
0.115.3
Description
Mobs, players, entities, all do not drop any loot
Steps to reproduce
kill any mob
Mod list
farmer's delight refabricated
nether's delight
Logs
No response
Minimal instance
- I have tested this on a minimal instance
Performance and shader mods
- I am using performance or shader mods
I don't know if this is the same issue, but fully-grown wheat and grass have both stopped dropping straw for me since the latest update. They still drop vanilla and other mod items (seeds, wheat, altered seeds from another mod).
Just wanted to chime in that this is definitely still an issue. Used a minimum test harness of this mod and Fabric API, and it still happens.
so just to be clear, the loot from any entity doesnt work? i tried killing a zombie and it did drop stuff
this seems very odd as so many use the mod and if the mod made all entity loot invalid it would be a huge bug and so many more people would be commenting here
I came to find out if anyone else was having an issue getting straw from wheat, and ended up digging into the code.
Turns out my issue is caused by line 59 of LootTableModifications.java, it calls key() on wheat, as if it's a Farmer's Delight block. It should be vanillaKey(). Changing this fixes that bug, but I don't have the time to make a full pull request about it at the moment.
Ok so it just affects wheat not all blocks and entities?
I'll change that in the msan time
Ok so it just affects wheat not all blocks and entities? I'll change that in the msan time
Can't speak for the issue author, but that was what was affecting me. Glad it got fixed though! Thank you!
Ok so it just affects wheat not all blocks and entities?
Wheat and grass were the problem areas for me too. (Hmm, wheatgrass smoothies - future update? Joking, joking.)
Thank you for looking into this! Your mod is one of my absolute must-haves. I don't upgrade to new Minecraft vers without it. I use the cabinets everywhere!
