Farmer's Delight Refabricated

Farmer's Delight Refabricated

Mods
12M Downloads

Multiple `ItemStackHandler#getStackInSlot` calls will make previous references lose synchronization

Closed this issue ยท 2 comments

commented

Minecraft version

1.21.1

Farmer's Delight version

3.0.1

Fabric Loader version

0.16.4

Fabric API version

0.103.0+1.21.1

Description

Multiple ItemStackHandler#getStackInSlot calls will make previous references lose synchronization

https://github.com/MehVahdJukaar/FarmersDelightRefabricated/blob/fabric/1.21.1-3.0.0/src/main/java/vectorwing/farmersdelight/refabricated/inventory/ItemStackHandler.java#L48-L53

Steps to reproduce

No response

Mod list

N/A

Logs

No response

Minimal instance

  • I have tested this on a minimal instance

Performance and shader mods

  • I am using performance or shader mods
commented

so i wasnt the one that coded that but i believe just replacing that put with a computeIfAbsent should solve this

commented

The relevant method has been removed in 3.1.0, which means that this issue can be closed for good now.