Minecraft version

1.21.1

Farmer's Delight version

1.2.7

NeoForge version

21.1.115

Description

I was testing my mod for compatibility with yours, and I noticed that your crops were mysteriously breaking themselves. My dimension sows a lot of unhydrated farmland with random crops, and it looks like your cropblocks don't implement the vanilla behavior of preventing the decay of farmland they're planted in.

Adding the vanilla tag "maintains_farmland" to your cropblocks seems to fix the problem. As your mod doesn't try to add this tag, I didn't feel the need to test a minimal instance.

Steps to reproduce

You should be able to reproduce this by:

1. Till farmland far from water (and out of rain),
2. plant crop,
3. watch the farmland decay and the crop pop out.

It's probably faster if you speed up (random?) ticks.

Mod list

Logs

No response

Minimal instance

• I have tested this on a minimal instance

Performance and shader mods

• I am using performance or shader mods

A patch on my end:

    tag(MAINTAINS_FARMLAND)
            .add(TagEntry.optionalElement(ResourceLocation.fromNamespaceAndPath("farmersdelight","cabbages")))
            .add(TagEntry.optionalElement(ResourceLocation.fromNamespaceAndPath("farmersdelight","onions")))
            .add(TagEntry.optionalElement(ResourceLocation.fromNamespaceAndPath("farmersdelight","rice_panicles")))
            .add(TagEntry.optionalElement(ResourceLocation.fromNamespaceAndPath("farmersdelight","budding_tomatoes")))
            .add(TagEntry.optionalElement(ResourceLocation.fromNamespaceAndPath("farmersdelight","tomatoes")));

The rice still breaks, but that's fine. It can't survive outside water. If this tag fixes the behavior, you should probably add it during your data gen.

This tag seems to have been added late in 1.20, so it skipped my radar. I'll test locally and add them if needed.

Alright... In 1.20.1 the tag exists, but isn't yet enforced, so the crops still stand. In 1.21, however, the tag is used for the check, causing the bug you mentioned.

I'll add the tags to both versions in the upcoming patch.

Added on commit cb10ae4.