Farmer's Delight

Farmer's Delight

97M Downloads

[1.16.4] [Upcoming] Rich Soil issue involving saplings and giant spruce trees

vectorwing opened this issue ยท 1 comments

commented

Note: This is an upcoming 1.16.3 and 1.16.4 release issue. It does not apply to 0.2.4b or earlier versions.

Description
To fix issue #96, Rich Soil must be added to the tag forge:dirt. However, Giant Spruce trees also make use of this tag to determine which blocks can be replaced with Podzol. Because of this, all nearby Rich Soil will be converted to Podzol during a Giant Spruce growth, if added to this tag.

Since users are encouraged to place Organic Compost near blocks like Podzol to accelerate it, or might consider speeding up a Giant Spruce tree with Rich Soil, this issue could make players lose a lot of soil they've been working to get, so a fix is important.

The only promising solution so far is to insert a mixin to the AlterGroundTreeDecorator class, making it ignore Rich Soil when checking for suitable blocks. Given I am inexperienced with mixin, I'm making this issue as a reminder to study up on it, and fix it separately from other enhancements. Help wanted.

Steps to reproduce:

  1. Add Rich Soil to the forge:dirt tag;
  2. Place a cluster of Rich Soil on the ground;
  3. Plant a 2x2 of Spruce Saplings near the cluster, and make it grow.

Expected behavior:
Rich Soil should survive Podzol conversion, while also being able to grow saplings into trees.

commented

Fixed by @Jozufozu on pull request #124.