[1.16.4] Unable to apply 'comfort_foods' tag using CraftTweaker

Question

[1.16.4] Unable to apply 'comfort_foods' tag using CraftTweaker

jengendler opened this issue 4 years ago · 10 comments

jengendler commented 4 years ago

Description
I am trying to add the 'farmersdelight:comfort_foods' tag to all soups and stews from this mod and others with CraftTweaker. I can confirm I am using the correct ZenScript/CraftTweaker syntax because I can add custom tags to soups and stews, but the comfort_foods tag does not appear to apply, nor does it give an error. Is it even possible to add this tag via CraftTweaker?

Steps to reproduce:
In CraftTweaker, I have the following code:
<tag:items:farmersdelight:comfort_foods>.add(<item:farmersdelight:chicken_soup>); <tag:items:farmersdelight:comfort_foods>.add(<item:pamhc2foodcore:noodlesoupitem>);

Expected behavior:
After saving the above .zs to the scripts folder, and entering /reload in Minecraft, no comfort_foods tag appears to apply when viewing NBT tags / hidden tooltips. I have tried 'comfort_food' without the 's', which does apply, so I know the syntax is correct.

vectorwing · Answer 1 · 2021-01-24T03:11:29.000Z

Hey there! Although you stated there was no error, could you post the CraftTweaker logs here anyway? And perhaps the game's debug.log too, if you got it. Might still have something useful in there to troubleshoot.

Also, pardon me a bit, I'm generally unfamiliar with CraftTweaker, so I'm polling some help on this issue. x)

jengendler · Answer 2 · 2021-01-24T23:30:12.000Z

@jengendler Update Crafttweaker, the latest https://www.curseforge.com/minecraft/mc-mods/crafttweaker/files/3179182 should work on 1.16.4 and may fix the issue.

Updated to the latest CT file, but I still don't see the tag applied in the tooltip of the Chicken Soup item. As I said above, the Comfort Food effect still occurs when eating your soup and stew items, they just don't have the tag applied to the item.

Github does have Zenscript highlighting support though!

Amazing, thanks!

jengendler · Answer 3 · 2021-01-24T21:30:48.000Z

No problem. I decided to duplicate my instances of MC and removed most mods (and was able to reproduce the issue) so that the log files would be shorter. Here is the mod list:

Mods:
[✔️] CraftTweaker-1.16.4-7.1.0.84
[✔️] FarmersDelight-1.16.3-0.3.1
[✔️] jei-1.16.4-7.6.0.62
[✔️] jeiintegration_1.16.4-6.1.1.11
[✔️] modnametooltip_1.16.2-1.15.0
[✔️] theoneprobe-1.16-3.0.6

Log files attached.
crafttweaker.log
debug.log

Also here are the full contents of my ZenScript file (as GitHub doesn't accept .zs file uploads). Any line trailing // characters is a comment.

// Main [CraftTweaker]

import crafttweaker.api.item.IItemStack;
import crafttweaker.api.item.IIngredient;
import crafttweaker.api.tag.MCTag;

// ADD TAG
// MCTag.add(items as T[]) as void
// Examples:
//<tag:items:forge:gems>.add(<item:minecraft:bedrock>);
//<tag:items:forge:gems>.add(<item:minecraft:iron_ingot>, <item:minecraft:gold_ingot>);
//<tag:items:forge:gems>.add([<item:minecraft:iron_ingot>, <item:minecraft:gold_ingot>]);

<tag:items:farmersdelight:comfort_foods>.add(<item:farmersdelight:chicken_soup>);

Also to note, I know I can apply other modded tags to items in-game with CraftTweaker, as I was able to do it successfully by applying a Buzzier Bees tag to an item in Extended Lights. (Adding the tag <tag:items:buzzier_bees:candle_base>.add(<item:extlights:wax_lump>); let's me use Extended Light's wax as an appropriate ingredient in Buzzier Bees candles.)

Thanks for looking into this!

jaredlll08 · Answer 4 · 2021-01-24T21:52:41.000Z

@jengendler Update Crafttweaker, the latest https://www.curseforge.com/minecraft/mc-mods/crafttweaker/files/3179182 should work on 1.16.4 and may fix the issue.

as GitHub doesn't accept .zs file uploads

Github does have Zenscript highlighting support though!, so you could do:
```zenscript
code
```
to get some highlighting, like so:

// Main [CraftTweaker]

import crafttweaker.api.item.IItemStack;
import crafttweaker.api.item.IIngredient;
import crafttweaker.api.tag.MCTag;

// ADD TAG
// MCTag.add(items as T[]) as void
// Examples:
//<tag:items:forge:gems>.add(<item:minecraft:bedrock>);
//<tag:items:forge:gems>.add(<item:minecraft:iron_ingot>, <item:minecraft:gold_ingot>);
//<tag:items:forge:gems>.add([<item:minecraft:iron_ingot>, <item:minecraft:gold_ingot>]);

<tag:items:farmersdelight:comfort_foods>.add(<item:farmersdelight:chicken_soup>);

jengendler · Answer 5 · 2021-01-24T21:55:28.000Z

Update! I did a lot more testing. It looks like trying to add the tag to Farmer's Delight foods doesn't work, because the food already has the Comfort Foods effect upon eating, but it doesn't show up as a tag. I just testing eating the chicken soup with and without the CraftTweaker script. Both times the comfort foods buff applied after eating that soup.

I also then tried testing adding the buff to a different mod's food item and it successfully displayed the tag on the item tooltip (which I can see with other mods like JEI Integration) and it also successfully applied the Comfort Foods buff after eating.

So I guess the fact that I couldn't see the tag on the Farmer's Delight food item led me to believe it wasn't going to apply the buff. I apologize, as I should have testing eating the item before submitting this issue. However, it would be nice for your food items to have all their appropriate tags applied to help make JEI searching easier, and see what kind of buffs/effects items might give. Not sure if that's possible with how your mod is coded, but it would be nice to have consistency when searching by your mod's tags in JEI.

Also, this is my FAVORITE food mod in the game. Your graphics/models/textures/animations/etc. are so polished and look so beautiful in the game. The quality is on par with what the Mojang team themselves release. Just excellent work all around.

vectorwing · Answer 6 · 2021-02-28T02:54:17.000Z

@jengendler Thank you for the kind words, and sorry for the late reply! 😄

I know this is rather old, but I'm still unsure why the tags themselves didn't apply to the items. Even if the effect is already into the item (e.g. Chicken Soup), it should still be able to obtain the tag, by Minecraft's own code. Did you have success tagging it, or is it still bugged? Alternatively, are you able to manually tag it with a datapack, or do both it and CT fail?

I'm actually considering removing this tag in the future. It doesn't permit good customization of the effect's length or power (it's always 5 minutes), and customizing effects in general is a hard ordeal, due to them being a coded item property.

jengendler · Answer 7 · 2021-03-12T18:03:52.000Z

I can do more tests, as I have only tried CT thus far. I really do like this effect and would be sad to see it go, but don’t think it would compromise the awesomeness of the mod at all.

jaredlll08 · Answer 8 · 2021-03-19T21:53:49.000Z

This is an issue with CraftTweaker, we don't have a fix for it implemented yet, but we have some idea on how to resolve it.

jaredlll08 · Answer 9 · 2021-03-21T00:31:56.000Z

This has been fixed in CraftTweaker/CraftTweaker@c188288 and will be released on CurseForge shortly.

This issue can be closed

vectorwing · Answer 10 · 2021-03-21T00:33:04.000Z

Thank you so much, @jaredlll08! 😄

Share to