Farmer's Delight

Farmer's Delight

Mods
77M Downloads

[1.18.2] Knife with Backstabbing on main hand applies the effect to any damage the player gives

vectorwing opened this issue · 2 comments

commented

Description
If a player is holding a Knife enchanted with Backstabbing on their main hand, any damage this player delivers to mobs will receive the backstab multiplier. This can potentially lead to extreme damage scaling where it shouldn't happen.

Steps to reproduce:

  1. Enchant any Knife with Backstabbing;
  2. Hold the Knife in your main hand;
  3. Deal damage to a mob using the off-hand (for example, a Bow).

Expected behavior:
Backstabbing should only apply to the enchanted knife's attacks, nothing else.

Mod list:
Farmer's Delight 1.18.2 - 1.2.0
Forge 40.1.46

commented

Issue #603 is related to, or caused by, this bug.

  • 👍1
commented

This bug no longer applies as of 1.20.1 and above. 🎉
1.21, especially, has inherently fixed this issue due to how enchantment applications are calculated; it now considers the proper source of damage on the mainhand.