Description

Wild crops aren't generating in any modded biomes. I've tested this with Biomes O'plenty, Oh the Biomes You'll Go, Terralith, and William Wyther's Overhauled Overworld. I even played a modpack that used Farmer's Delight and BYG and still noticed the same issue. Crops are only spawning in the vanilla biomes.

(Wyther's Deep Desert)

(Vanilla Desert)

Steps to reproduce

1. Install Farmer's Delight 1.18.2 and any biome mod
2. Generate a world
3. Look in the modded biomes and you'll notice no crops have generated

Mod list

Farmer's Delight 1.18.2-1.2.0
William Wyther's Overhauled Overworld 2.6.3-1.18.2
Forge 40.1.73

Logs

No response

Forge

• I am using the Forge version of Farmer's Delight

Minimal instance

• I have tested this on a minimal instance

Performance and shader mods

• I have tested this without performance or shader mods

This is related to two other issues: #675 and #622.

Basically, FD filters wild crop spawning to biomes tagged as forge:is_overworld, which Wythers does not use. Instead, it uses sub-tags speficying overworld per biome tag.

I'm adding a different check to prevent non-Overworld generation, and it's working properly with Wythers in my tests.

The fix I applied on commit 2daa6e5 worked for every other biome mod in my tests, except Wythers. When this mod is installed, neither vanilla nor Wythers biomes generate any modded vegetation, including from a few other mods I tested. 🤔

Might be worth forwarding this issue to the Wythers mod's issue board, @Optify1.

Since the issue referred to other biome mods as well, the fix still applies. I'll close this one for now, but if you get a return from Wythers, feel free to reply here. 👍