Kicked out from vanila server with Internal exeption

Question

Kicked out from vanila server with Internal exeption

i218 opened this issue a year ago · 20 comments

i218 commented a year ago

Minecraft version

1.18.2

Farmer's Delight version

1.2.3

Forge version

40.2.9

Description

Kicked out from vanila server with this msg

(with only Farmer's Delight installed same thing happens)
Singleplayer works normaly.

Steps to reproduce

Trying to connect vanila server.
Server works like that, but i cant enter vanila.
Velocity (with plugin) -> Vanila -> Modded

Mod list

It may be easier to read like that:
modlist.txt

Logs

No response

Minimal instance

I have tested this on a minimal instance

Performance and shader mods

I am using performance or shader mods

GGrandma · Answer 1 · 2023-09-07T21:00:56.000Z

can reproduce

Minecraft: 1.20.1
Forge: 47.1.0
Farmer's Delight: 1.2.2, 1.2.2a, 1.2.3

i218 · Answer 2 · 2023-08-30T20:02:06.000Z

There was also another tester with a different message

Hellicious · Answer 3 · 2023-09-19T09:39:15.000Z

Have the same issue, Minecraft version 1.20.1, Forge 47.1.0, Farmer's Delight 1.2.3

i218 · Answer 4 · 2023-09-09T16:37:02.000Z

Repo?

can repo

Minecraft: 1.20.1 Forge: 47.1.0 Farmer's Delight: 1.2.2, 1.2.2a, 1.2.3

GGrandma · Answer 5 · 2023-09-10T03:04:11.000Z

Sorry meant reproduce, edited.

Xing-C · Answer 6 · 2023-09-24T01:40:30.000Z

This prevented me from joining the bungee server, and I received the same error. After a day of investigation, I found out that it was due to this mod

bananababoo · Answer 7 · 2023-09-25T19:25:50.000Z

Had the same issue today, exact same error message as @Hellicious.

p0t4t0sandwich · Answer 8 · 2023-09-25T20:20:26.000Z

Just going to throw my two sense in here.
Once Forge 1.20.2 and server proxies get the new protocol all hashed out, this issue is going to become a lot more widespread, as nobody in their right mind would waste resources on a modded hub, especially if they're running multiple modpacks under the same proxy.
It would be in your best interest to finally get this issue properly fixed.

vectorwing · Answer 9 · 2023-09-25T21:07:25.000Z

Seems to be similar, or duplicate, to issue #810.

Forge mods are not meant to be compatible with vanilla servers, thus shouldn't be expected to work in such cases. That said, I had no idea so many users were adopting this proxy server system, instead of making a separate modded instance.

Connection errors trigger Netty exceptions, which are apparently swallowed by Forge; so logs provide no information. I have zero clue as to why FD could be causing this, when no other mod does so.

To folks in this thread, please help me out by doing the following steps:

Download and install this mod: https://www.curseforge.com/minecraft/mc-mods/spit-it-out
Attempt to connect again;
Grab both client and server logs, if possible, and post them here.

wolflord212312 · Answer 10 · 2023-09-25T21:32:56.000Z

Clinet:
https://mclo.gs/spfCkge Latest
https://mclo.gs/UOyBLDb Debug

Proxy:(all the way to the bottom ignore other errors look for DjJewl)
https://mclo.gs/kqOsRn3

Vanilla Server: Ignore other errors
https://mclo.gs/Izro3zl

p0t4t0sandwich · Answer 11 · 2023-09-25T21:58:46.000Z

Only mods in use are FD and Spit It Out

Paper Server With No Proxy

Client (Forge 47.2.0): https://mclo.gs/RkpB99T
Server (Paper 1.20.1 v196): https://mclo.gs/Lchb5re

Paper Server With Velocity and the Ambassador Velocity plugin

Client (Forge 47.2.0): https://mclo.gs/wILKm6u
Server (Paper 1.20.1 v196): https://mclo.gs/8kx4RnB
Proxy (Velocity v265): https://mclo.gs/FWJyHj5

Paper Server With Velocity without Ambassador

Client (Forge 47.2.0): https://mclo.gs/MpyczWK
Server (Paper 1.20.1 v196): https://mclo.gs/7wYXgeN
Proxy (Velocity v265): https://mclo.gs/WIPQf8P

GGrandma · Answer 12 · 2023-09-25T23:45:31.000Z

Client

Minecraft: 1.20.1
Forge: 47.1.0
Farmer's Delight: 1.2.3
Spit It Out: 1.0.0
https://mclo.gs/bLkblOo
https://mclo.gs/ppxvpMp

Server

Velocity: 3.2.0-SNAPSHOT # 265
Paper: 1.20.1 # 170
Plugins: Ambassador, Floodgate, Geyser

vectorwing · Answer 13 · 2023-09-26T02:50:23.000Z

After a lot of asking around, I figured out what the problem is, and I have bad news. :(

FD adds a vanilla recipe book to the Cooking Pot, and to do so, it must extend the RecipeBookType enum. However, vanilla assumes the RecipeBookType enum is non-extendable, while Forge makes it extendable. This works fine in a modded client/server connection, but a vanilla server does not expect the enum to be bigger on the client, which causes the packet to be too large.

Due to the nature of Java enums, there is no good way for me to fix this on FD without completely removing the Recipe Book integration, which is not something I can do. This issue would have to be fixed in either Bungeecord (ignoring modded enum entries) or in NeoForge; nothing I can do on my end.

I'll open an issue in NeoForge regarding this conflict, as it affects consumers of its recipe book integrations.

Sorry for the inconvenience, folks. 😞

p0t4t0sandwich · Answer 14 · 2023-10-03T10:22:54.000Z

So funny story, I had the idea to use Protocolib on the Paper server to just tactical nuke any recipe book packets, and that surprisingly worked. The caveat there being that the recipe book doesn't function, but if you were to have this on a hub server, the recipe book should fix itself when joining the Forge server.
(I also highly doubt you'd make much use of the recipe book on the hub server anyway)

p0t4t0sandwich · Answer 15 · 2023-09-26T08:32:38.000Z

Thanks for taking the time to look into it! Hopefully they'll be able to figure something out upstream, or worst case, some proxy dev figures out a fix/workaround.

i218 · Answer 16 · 2023-10-03T18:27:55.000Z

So funny story, I had the idea to use Protocolib on the Paper server to just tactical nuke any recipe book packets, and that surprisingly worked. The caveat there being that the recipe book doesn't function, but if you were to have this on a hub server, the recipe book should fix itself when joining the Forge server. (I also highly doubt you'd make much use of the recipe book on the hub server anyway)

Could u help me do the same thing pls? (Cause i never heard about Protocolib before)

p0t4t0sandwich · Answer 17 · 2023-10-03T20:22:10.000Z

Yeah for sure, I'm drafting up a Git repo today so that others will be able to use it.
I honestly wonder how many of those weird packet errors can be solved this way

p0t4t0sandwich · Answer 18 · 2023-10-03T23:21:11.000Z

Got it published here, currently working on a less brutal implementation
https://github.com/p0t4t0sandwich/ModPacketFix/releases

Xing-C · Answer 19 · 2023-10-04T07:05:46.000Z

Got it published here, currently working on a less brutal implementation
Perhaps this is not the correct fix, but it is a good idea

p0t4t0sandwich · Answer 20 · 2023-10-04T12:11:53.000Z

Fixed it so that it's a bit smarter with removing the Recipe book packet, it shouldn't effect vanilla users now.
With the way Ambassador reconnects the Forge client, the recipe book is restored when the Forge client logs into the Forge server.

Share to