StructureGenerationChunkProvider might be retaining chunks forever.
fluffle opened this issue · 8 comments
Hi!
I'm playing TechNodefirmacraft, a mod pack that includes this mod. I've run into some problems with performance on my server (Bunsan/TechNodeFirmaCraft#46) that I have traced back to constant concurrent-mode garbage collections. I grabbed a heap dump while the server was in this state and found that it had over 7000 chunks on the heap.
As I stated on the other bug:
2545 are directly held live by a farseek.world.gen.structure.StructureGenerationChunkProvider and its loadedChunks hash map. Another 4756 are directly referenced by nothing in particular according to the MAT dominator tree, but some poking around finds a com.bioxx.tfc.Chunkdata.ChunkDataManager that appears to be holding references to most of them.
The comment on line 47 is telling:
// Note that since we don't recreate structures on world load, reloaded chunks can be "generated through" and won't be unloaded, but this should remain a small number
Is this what's happening to me? I don't quite understand the comment and i'm not particularly familiar with Scala, but it does seem a little coincidental :-)
Hi fluffle!
Thanks for letting me know about this, I will take a look at get back to you.
-delvr.
This should be fixed in the new 1.9.4-2.0 version; I will look into backporting the fix to 1.7.10 when I get the chance.
Hi there; I am having this exact same problem with TerraFirmaCraft and Streams; StructureGenerationChunkProvider causes my server to time out and stop working, preventing exploration.
I don't want to seem rude or needy, but has there been any progress on backporting a fix for this to 1.7.10? Thank you!
Sorry for the delay that one - backporting of this and other fixes in in progress. I'm seeing some incompatibilities with TFC which are being worked on.
I backported the fix in Farseek 1.1 for 1.7.10: https://minecraft.curseforge.com/projects/farseek/files/2377895 . Please give it a try and let me know if it improves things.