Describe the bug you're experiencing

Singleplayer world freezes when saving if there is a goblin from the Goblin Traders mod. The freeze is infinite and forces to close the game.

I really don't know if this is a Goblin Traders problem or this mod's problem, but I hope to find a solution. Both mods are open source, so maybe we can identify the problem in the code, dunno. In fact, Goblin Traders 1.11.3 seems to change something related to saving stuff. I'm not familiar with Minecraft modding, so I don't know if that could be the issue...
I have a big modpack and this is the only issue with these mods, so far.

It would be great to find a solution so that we can all play with these fantastic mods at the same time :)

Thx in advance

Here are all my relevant logs
Minecraft crashed without a crash report. The logs have been uploaded to gnomebot.dev:
latest.log | debug.log head / tail (~56k lines) | PrismLauncher-0.log | crash_assistant_app.log | win_event1756032775577.txt | modlist.txt | i7-13700k can be reason of crash
Found 1 log analysis results:
WasClosedByWindows in: win_event1756032775577.txt

Mod list changes beyond the latest successful launch:
Mod list wasn't modified.

Reproducability

FastAsyncWorldSave 1.20.1-2.4
Goblin Traders 1.11.5

Spawn/find a goblin trader.
Wait for the asyncronous save. Edit: I think it's really a matter of waiting. The freeze triggered when opening JourneyMap waypoint manager, but the log tells another story.
Game freezes.

Mod up to date

• Before submitting this issue I updated to the newest version and reproduced it

Minecraft version

1.20.1

Modloader version

Forge

Logs

https://gnomebot.dev/paste/mclogs/j5ZqrFm

The freezing is unrelated to fast async worldsave, the log you see happens after it finished its operation. Though it did fail to write data to save to the file, as goblin traders is using an invalid name for windows filesystem.
I'll add a fix for their filenames, though it probably wont fix the freeze

Hello someaddons.

Yeah, that filename doesn't seem right. I haven't seen anyone using the mod having issues tho, but who knows...
Regarding the freeze and the fix you propose (great news 😀👍), you also say that it won't probably fix it. Is it due to something in particular you saw in the logs? What do you think?

Thx again.

there is nothing else in the logs, I think the freeze may be related to journeymap at least I had freezing issues with it some time ago
I just uploaded a new version to curseforge that'll auto fix the filename, the saving should no longer error with it

Okay, I'll try again this week.
I've never experienced problems with JourneyMap. Maybe my Raptor Lake CPU is indeed freezing the game, dunno...

Thank you very much!

Hello someaddons. I've tried the new version and now it doesn't crash. I'll close the issue.
Thank you very much for your work :)