Fast Vanilla Furnaces

Fast Vanilla Furnaces

12.9k Downloads

[1.12.2] PiTweaks Overriding CraftTweaker Recipes

jonqrandom opened this issue ยท 5 comments

commented

i have the following in my recipes.zs, the button recipes are working fine, the pressure plate recipes are being overriden by pitweaks. please could you avoid overwriting recipe changes made by crafttweaker (and other recipe managers), as they should always be the final decider in any pack. in my particular circumstance, the pitweaks recipe for pressure plates is conflicting with quark's generic slabs-to-blocks recipe, and i'm not prepared to release a pack that relies on NoMoreRecipeConflict to function.

commented

What does "conflicting" mean here? Are you not able to convert slabs to blocks using the Quark recipe? PiTweaks adds a slab-to-blocks recipe that's shapeless, so you should be able to get the blocks back by putting them anywhere in the grid.

The 2x2 recipes tweak is probably not compatible with Quark anyway because they both try to tweak stair and slab recipes, and they both add a slab-to-block recipe. If you're using Quark, you might want to turn off the 2x2 tweak.

Right now, PiTweaks just scans the recipe list for stair/slab recipes and adds the new ones dynamically (same as Quark). I have no control over when other mods' recipes get added. I'll see if I can make it more aware of existing recipes though.

commented

i'm not asking you to change recipes, i can (normally) deal with recipe conflicts just fine. i was mentioning the particular issue that brought this to light, but it's not the root of the problem. i have
recipes.remove(<minecraft:wooden_pressure_plate>); recipes.remove(<minecraft:stone_pressure_plate>);
in my script, yet i'm still seeing pitweaks pressure plates recipes, and not the ones i add. JEI is quite specific that the recipe (2x stone/wood slabs) comes from pitweaks. i can check crafttweaker's docs, but as far as i'm aware it's loading its changes as late as possible in order to be able to override everything else.

EDIT: ok, i just removed pitweaks to check, and without pitweaks, my pressure plate recipes (1 slab = 1 pressure plate) load just fine. with pitweaks, the pressure plate recipes i set are being removed, and the pitweaks ones are set instead.

EDIT2: tested in fresh instance with only forge, pitweaks and crafttweaker. same result.

commented

Here is a suggestion so that you don't have to redesign your whole existing recipe checks and stuff:

you could add dependencies="before:crafttweaker" to you @Mod annotation to load before crt so the post init events don't conflict with each other.
Current problem is that P is after C in the alphabet and therefore it is able to overwrite it.

This will not give you a hard dependency on crafttweaker.

commented

I decided to go with a simpler approach. I added a config option to disable all pressure plate handling in PiTweaks, so that people using crafttweaker can customize however they want and my mod will stay out of the way.

Does this solve your problem?

commented

sure, that'll do it, thanks :)