FastSuite

FastSuite

18M Downloads

Crash (CME) with various TerraFirmaCraft recipes involving non-threadsafe `getCapability`

alcatrazEscapee opened this issue ยท 0 comments

commented

Minecraft 1.20.1

crash-log-1.txt
crash-log-2.txt

I'm reporting this for posterity reasons - it is in all but mod and specifics, the same issue as #36. TerraFirmaCraft has a not threadsafe capability (it's worth mentioning, Forge capability initialization on item stacks isn't assumed threadsafe, because it's lazy with no locks). In this case, TFC has a capability which deserializes a list one element at a time, and an ingredient which may end up checking the state of this list (involving iterating over it), aka CME when used in parallel via fast suite's parallel recipe matching.

FastSuite matching recipes in parallel is not safe here. This would be likely fixed by #27 , when such a feature is implemented.