1.16.4 Silent Gear's repair kit misbehaves with FastWorkbench
FreeFull opened this issue ยท 5 comments
The following issue seems to only occur with FastWorkbench installed: SilentChaos512/Silent-Gear#237
When a repair kit is being refilled by crafting it with a material, the output seems to only consider the materials that were there before the repair kit was put into the crafting slot.
For example, if you put in a repair kit in slot 1, cobble in slot 2 and cobble into slot 3 of a crafting table, in that order, the crafting output (filled repair kit) will only contain the first piece of cobble instead of both.
Can confirm that on version 4.5.0 of the mod, the issue with dynamic recipes persists
Sophisticated Backpacks dye recipes have their result disappear once second dye is put in the crafting grid.
Appears to be a line of code missing above this one which would simply get the new crafting result from recipe, now it just sends an empty ItemStack to client.
https://github.com/Shadows-of-Fire/FastWorkbench/blob/1.16/src/main/java/shadows/fastbench/gui/ContainerFastBench.java#L83
This affects other Silent Gear recipes as well, including gear crafting recipes. Any dynamic recipe, it seems. The output never gets updated after the first match.
The criteria where a recipe would remain matching after an input change apparently was not considered, nor encountered, up until this point. I'll probably have to make it where dynamic recipes always send an SPacketSetSlot.