FastWorkbench

FastWorkbench

70M Downloads

[bug] Shift-craft custom recipe may cause infinite loop.

khjxiaogu opened this issue ยท 2 comments

commented

If a recipe whose getCraftingResult return EMPTY while matches return true, crafting this recipe would cause the game stucks. I know this is incorrect but this won't cause trouble without FastWorkBench. Adding one more check would improve compatibility and robustness.

commented

That's not supported behavior, the only thing I might do is fire a proper exception.

commented

That's not supported behavior, the only thing I might do is fire a proper exception.

Maybe do another check, log a warning and break that loop would be more friendly.