First Aid

First Aid

15M Downloads

Tinkers compatibility issue

Scortan opened this issue · 4 comments

commented

Like the mod
does not work with tinkers armour
example
diamond helmet gives like 13? location defence
tinkers helmet give lets say 15 defence so it should be stronger but no
the tinkers helmet does not become specific to location and since there hp bar it gives not defence at all meaning that all tinkers armour has 0 defence if using this mod.
plz look into it i Iike this mod but its pretty annoying if using tinkers and a modpack where there is a lack of diamonds and vanilla materials. i get 1 shot by most mobs that are slightly stronger than vanilla stuff. even skeles with slightly stronger bows always get head shot insta kills.

lots of love
some dude

commented

I noticed the same behavior, but I believe it has to do with the way that Construct Armory calculates defense based on user choice vs having a fixed defense.
If you take the base items (for example comarm:helmet) it has 0 for defense durability and toughness. The defense, traits, and attributes are based on NBT tags.
I may just be stupid, but an if conitdional for conarm that then reads the NBT tag called Stats for defense or toughness could fix it.
If you decide to implement compatibility I would be greatful, but I can understand not implementing it while focusing on the 1.14.x releases.
Even if you decide not to, just giving me a hint as to where to look to implement this in the code, and I would fork it.

Thanks for all the awesome work. Keep it up!

Images of base helmet item and higher tier helmet item for in-game comparison:

image

image

NBT Data for Up-Tier Helmet
image

EDIT:
Possibly need to implement an NBT tag check during ArmorUtils>applyArmor()
If I can get forge set up, and figure out this "References non existing library 'Morepheus-deobf.jar'"
It seems so much harder to get a Java IDE to function in Linux for some reason. Just a learning curve I'm sure.

commented

Fixed in 1.6.11

commented

I can't find a mod called tinkers armor, and I don't think tinker's construct has armor. Can you send me a link to the mod?