request: removal of the “Enabled by Default” option
peow opened this issue · 9 comments
I can't see the point of this option, I think the mod should just follow the last state in which the user left Firstperson, if disabled when opening the game again it will remain disabled, if enabled it remains enabled
(and when opening the game for the first time it would obviously be enabled)
As with the Iris mod, for example, in the mod's settings there is a line that defines whether the shaders are active or not.
a hypothetical situation could be where the FirstPerson-Model is in a modpack, and a random user doesn't like to see their model in the first-person view, but this user is a layman and doesn't understand about ModMenu and mod configuration, they just downloaded it and are playing, they will see the hotkey (F6) saying about toggling the mod, and they will have to use it every time they reopen the game, which would piss him off
if you agree to this change I ask for an update to 1.20.1, thanks for reading
I understand your perspective but having the option there isnt really bad. I have a server where some friends actually lose frames because of this mod. I have tested it myself that s having the model off actually raises fps. The option of some people having it on or off should stay because some people can have it on and some people want it off
i see, First-Person Model is a Client-side mod, someone who doesn't want it can remove it, another thing is that by removing the “Enabled By Default” option, the person could still deactivate the mod, just pressing F6 once in the game, and the mod will never be active again.
if still have bad points with this change, just add a third option, instead of just OFF/ON you could have the option “FOLLOW HOTKEY” or something similar, where the mod would start disabled or enabled as the person left it previously, as I said in my comment above
I don't really get the point. This option is there for people that want the mod off by default, turning it on only for certain gameplay parts. Saving the on/off state of the hotkey would require a bunch of logic to not cause lag and would just cause confusion("HELP, suddenly the mod turned off and no matter what I do, even after a restart it's not fixed?!?" after accidentally pressing f6). And same with modpacks, where you want to give people the option to use the mod, but don't force them by default.
Saving the on/off state of the hotkey would require a bunch of logic to not cause lag
hmmmm, I don't understand why, isn't it just storing the state in the configuration file? just like the Iris mod does, does Iris also lose performance because of this? I imagine that using the hotkey just to change a line in the config file (First-Person: ON/OFF) and then this setting toggles the First-person would be simpler than making the hotkey state be stored, in a nutshell: using the hotkey wouldn't change the First-person directly, but the config file, and the config file would change the First-person
and would just cause confusion("HELP, suddenly the mod turned off and no matter what I do, even after a restart it's not fixed?!?" after accidentally pressing f6).
but the opposite can also happen, where people don't understand why the mod keeps deactivating itself when they reopen the game. A Toast notification could also be added when the hotkey is pressed for the first time, warning that the mod has been disabled and can be enabled again by pressing F6 (default). or writing in the ModMenu that the status of the mod is changed by pressing the F6 hotkey.
And same with modpacks, where you want to give people the option to use the mod, but don't force them by default.
in a modpack the .config folder is attached, so the configuration file with First-Person enabled or disabled would be in the modpack
I dont want to be annoying and try to dictate the direction of the mod, I just want to make a suggestion, but if you believe that the change would not be beneficial, thats fine
hmmmm, I don't understand why, isn't it just storing the state in the configuration file?
that would cause a lag spike
just like the Iris mod does, does Iris
You don't switch shaders on/off all the time and there is a lagspike when you do with the hotkey. No clue if they do the saving in the background.
but the opposite can also happen, where people don't understand why the mod keeps deactivating itself when they reopen the game.
It's on by default, so less likely people turn open the setting and turn it off by accident.
A Toast notification could also be added when the hotkey is pressed for the first time
All of that assumes people know about the hotkey. People more likely know how to access settings, than to check the hotkey screen for a hotkey they don't even know about.
Tbh, I really don't get the point of this issue. Why remove a feature just because it doesn't apply to you?
that would cause a lag spike
mmm, i see
You don't switch shaders on/off all the time and there is a lagspike when you do with the hotkey. No clue if they do the saving in the background.
Iris doesn't cause lagspike when you disable the shaders, only when you enable them, after all you're changing all the lighting in the game.
It's on by default, so less likely people turn open the setting and turn it off by accident.
I was imagining a modpack where by default the creator leaves it disabled, and warns the user that, if they want, they can press F6 to enable First-person
All of that assumes people know about the hotkey. People more likely know how to access settings, than to check the hotkey screen for a hotkey they don't even know about.
you could switch using both the hotkey and the ModMenu, that would be interesting
but I don't agree with people being more likely to check the settings instead of the hotkeys, after all the hotkeys are present in Minecraft Vanilla
Why remove a feature just because it doesn't apply to you?
it's not because it doesn't apply to me, I believe that others would also have this problem, and because I believe that it would be better without this feature, with the mod following the last state of First-Person (ON or OFF) when opening, or at least have the possibility to disable the Enabled/Disabled by default feature
I was imagining a modpack where by default the creator leaves it disabled, and warns the user that, if they want, they can press F6 to enable First-person
Thaaaats already how it is tho?
it's not because it doesn't apply to me, I believe that others would also have this problem, and because I believe that it would be better without this feature, with the mod following the last state of First-Person (ON or OFF) when opening, or at least have the possibility to disable the Enabled/Disabled by default feature
You are not asking for this feature to be removed, you are asking for a separate button that toggles the option in the settings instead.
I'd rather say that the feature should be removed because if you added the new feature and kept the old one it would be more work for you i think
as you didn't agree with the suggestion I imagine it would be better to close the issue as not planned, but thank you for replying and sorry for the inconvenience