Seems like there's no item except fish

Question

gousisme opened this issue 3 years ago · 1 comments

gousisme commented 3 years ago

I've tested a while and noticed that I couldn't get any other item from fishing, here's my latest.log:
latest.log

ExpensiveKoala · Answer 1 · 2022-08-17T17:44:20.000Z

Thanks for bringing this to my attention. I will try to fix this asap.

Steps to fix below (for my future reference):
It seems to be caused by https://github.com/ExpensiveKoala/Fishing-Real/blob/master/src/main/java/koala/fishingreal/FishingReal.java#L43 .result() when getConversionFromStack returns null if there is no conversion registered.