Fish's Undead Rising

Fish's Undead Rising

7M Downloads

Skeleton (minions) from other mods losing their target selector AI

WinDanesz opened this issue ยท 2 comments

commented

FUR version: 1.3.1
Other mods involved: Electroblob's Wizardry (or any other mod adding skeleton minions which are instanceof AbstractSkeleton)

A few users of Electroblob's Wizardry's skeleton summoning spells have reported that their various skeleton minions (new entities added by Wizardry) stopped engaging targets. The issue is present when FUR v1.3.1 is installed. After a quick glance, I'm suspecting that this logic in ModEventHandler causes the problem as it's purging the target selector of any entities. This logic might be feasible where only FUR is installed, but it will probably interfere with any other mods adding skeletons, especially those which are minions owned by players. I haven't done any further testing, but extending the filter by an additional check would probably help for most of these mods, e.g.:
if(event.getEntity() != null && event.getEntity() instanceof AbstractSkeleton && !(event.getEntity() instanceof IEntityOwnable && ((IEntityOwnable) event.getEntity()).getOwnerId() != null)) {

commented

2.0.0 for Minecraft 1.16.5 should fix this issue.
I'll update another fix for Minecraft 1.12.2

commented

Should be fixed in 31ecc9c