Flan (Fabric)

Flan (Fabric)

1M Downloads

[1.19.2] CarryOn not respecting Claims

itsdinkd opened this issue ยท 4 comments

commented

Modloader

Fabric

Minecraft version

1.19.2

Modloader version

0.76.0

Mod version

1.8.4.1

Description

Tschipp/CarryOn#487

users can enter another players base and pick up their blocks with 0 permission

Steps to reproduce

  1. add carryon mod
  2. have another player create claim
  3. enter that players claim
  4. pick up a chest for example using

Mods that might affect the issue

carryon

Logs

no log

commented

closing this due to stale and resolved?

commented

To add some context: Carry on will send out a BreakEvent before picking up a block. If that event is canceled, the pickup is denied.
Same for placement: it sends an EntityPlaceEvent first. I'm not sure how flan handles permissions, but most other permission mods that I've seen listen to some break events to cancel them on protected land.

commented

i cannot reproduce it. i do cancel the breakevent. and this works on my end.
this was tested on the 1.19.4 branch but the code for this part is the same on 1.19.2

2023-07-09.23-46-20.mp4
commented

It looks like the a new version of carryon "improved protection respection"

  • Fixed IMC messages not being sent
    - Now respects protections more
  • Fixed crashes
  • Added entries to default blacklist
  • Fixed bug where sneaking would conflict with carrying