Flan (Fabric)

Flan (Fabric)

1M Downloads

More Issues with Subclaims, Claims and a few Flan Suggestions!

suerion opened this issue ยท 2 comments

commented

Modloader

Fabric

Minecraft version

1.21.1

Modloader version

fabric

Mod version

flan-1.21.8-1.12.0-fabric

Description

Hey, i had some Issues and Suggestions:

I create yet this Issue, to combine my issues and suggestions:

  1. I had added the defaultClaimDepth on my config to 384, if i add an claim on the heigh from 320, to get to -64, but it use allways the point of the Claim position, The Claim does work right on -64 but the Subclaim does not work with this depth
  {
    "ID": "ac0144cd-262c-4f4d-91ca-c960907c9679",
    "Name": "%1$s #1",
    "PosxXzZY": [
      99,
      111,
      571,
      585,
      -64 -> is the right depth
    ],
    "Home": [
      105,
      126,
      578
    ],
    "EnterTitle": "\"You enter a secured area!\"",
    "EnterSubtitle": "",
    "LeaveTitle": "\"You left a secured area!\"",
    "LeaveSubtitle": "",
    "Potions": {},
    "AllowedEntries": {},
    "GlobalPerms": [
      "flan:enderman",
      "flan:drop",
      "flan:can_stay",
      "flan:snow_golem",
      "flan:enchantment",
      "flan:lock_items",
      "flan:portal",
      "flan:flight",
      "flan:pickup",
      "flan:enderchest"
    ],
    "PermGroup": {
      "Visitor": {
        "flan:door": true,
        "flan:button_lever": true,
        "flan:pressure_plate": true,
        "flan:enchantment": true,
        "flan:trapdoor": true,
        "flan:fence_gate": true,
        "flan:portal": true,
        "flan:enderchest": true,
        "flan:bed": true,
        "flan:itemframe_rotate": true,
        "flan:trading": true
      },
      "Co-Owner": {
        "flan:armorstand": true,
        "flan:archeology": true,
        "flan:edit_claim": true,
        "flan:projectiles": true,
        "flan:button_lever": true,
        "flan:break": true,
        "flan:pickup": true,
        "flan:enderchest": true,
        "flan:edit_perms": true,
        "flan:can_stay": true,
        "flan:open_container": true,
        "flan:boat": true,
        "flan:lectern_take": true,
        "flan:pressure_plate": true,
        "flan:noteblock": true,
        "flan:place": true,
        "flan:portal": true,
        "flan:hurt_animal": true,
        "flan:trample": true,
        "flan:wind_charge": true,
        "flan:ender_pearl": true,
        "flan:target_block": true,
        "flan:break_non_living": true,
        "flan:endcrystal_place": true,
        "flan:drop": true,
        "flan:claim_message": true,
        "flan:anvil": true,
        "flan:door": true,
        "flan:interact_sign": true,
        "flan:fence_gate": true,
        "flan:chorus_fruit": true,
        "flan:xp": true,
        "flan:hurt_named": true,
        "flan:jukebox": true,
        "flan:animal_interact": true,
        "flan:minecart": true,
        "flan:raid": true,
        "flan:enchantment": true,
        "flan:beacon": true,
        "flan:trapdoor": true,
        "flan:interact_block": true,
        "flan:redstone": true,
        "flan:bucket": true,
        "flan:bed": true,
        "flan:trading": true,
        "flan:itemframe_rotate": true
      }
    },
    "SubClaims": [
      {
        "ID": "f93b05cf-fd67-458e-9f7f-113d3681a87c",
        "Name": "",
        "PosxXzZY": [
          103,
          105,
          573,
          582,
          135 -> creating the subclaim on this heigh, no parenting of the depth or not adding the depth serting on subclaim
        ],
        "Home": [
          104,
          128,
          577
        ],
        "EnterTitle": "",
        "EnterSubtitle": "",
        "LeaveTitle": "",
        "LeaveSubtitle": "",
        "Potions": {},
        "Parent": "ac0144cd-262c-4f4d-91ca-c960907c9679",
        "AllowedEntries": {},
        "GlobalPerms": {
          "flan:enderman": true,
          "flan:drop": true,
          "flan:can_stay": true,
          "flan:snow_golem": true,
          "flan:enchantment": true,
          "flan:lock_items": true,
          "flan:portal": true,
          "flan:flight": true,
          "flan:pickup": true,
          "flan:enderchest": true
        },
        "PermGroup": {
          "Visitor": {
            "flan:door": true,
            "flan:button_lever": true,
            "flan:pressure_plate": true,
            "flan:enchantment": true,
            "flan:trapdoor": true,
            "flan:fence_gate": true,
            "flan:portal": true,
            "flan:enderchest": true,
            "flan:bed": true,
            "flan:itemframe_rotate": true,
            "flan:trading": true
          },
          "Co-Owner": {
            "flan:armorstand": true,
            "flan:archeology": true,
            "flan:edit_claim": true,
            "flan:projectiles": true,
            "flan:button_lever": true,
            "flan:break": true,
            "flan:pickup": true,
            "flan:enderchest": true,
            "flan:edit_perms": true,
            "flan:can_stay": true,
            "flan:open_container": true,
            "flan:boat": true,
            "flan:lectern_take": true,
            "flan:pressure_plate": true,
            "flan:noteblock": true,
            "flan:place": true,
            "flan:portal": true,
            "flan:hurt_animal": true,
            "flan:trample": true,
            "flan:wind_charge": true,
            "flan:ender_pearl": true,
            "flan:target_block": true,
            "flan:break_non_living": true,
            "flan:endcrystal_place": true,
            "flan:drop": true,
            "flan:claim_message": true,
            "flan:anvil": true,
            "flan:door": true,
            "flan:interact_sign": true,
            "flan:fence_gate": true,
            "flan:chorus_fruit": true,
            "flan:xp": true,
            "flan:hurt_named": true,
            "flan:jukebox": true,
            "flan:animal_interact": true,
            "flan:minecart": true,
            "flan:raid": true,
            "flan:enchantment": true,
            "flan:beacon": true,
            "flan:trapdoor": true,
            "flan:interact_block": true,
            "flan:redstone": true,
            "flan:bucket": true,
            "flan:bed": true,
            "flan:trading": true,
            "flan:itemframe_rotate": true
          }
        }
      }
    ]
  },
  1. If i change the Home Position from an SubClaim, it does not save it into the file

Screenshots created at 22:18 ->
Image

Image

Only if i add an new Home from an normal Claim -> (But the home has the same issue as point 1, it add the depth from config)
Image

Image
  1. I had tested the last Month a lot, the Changes from the Features are not allways trigger a "Save to File" sometimes it waits 5 minutes, sometimes it saves it within seconds. Don't know whats the reason of this, but it should allways trigger the save to file feature.

  2. Second Issue:
    #406

  3. Suggestions:
    #373
    #236
    #194

  4. Own Suggestion

Please add an Option if i would disable the Parent Option from other Claims for Subclaims.

Steps to reproduce

  1. Add Flan,
  2. Create Claim
  3. Create Subclaim
  4. SetHome for Claim or Subclaim

Mods that might affect the issue

No response

Logs

No informations in the Log, only the informations in the Client Chat.

commented
  1. no... the home position is correct. the default home position will take the highest solid block in the middle of the claim. the value you highlighted in the file is also the z value and not y
  2. files do NOT save immediately and this is indented. io tasks are resource intensive and should only be done when needed. and in this case its done whenever the server saves
  3. see above

for the rest there is no need to make an issue for that...
for the last one: dont make an issue containing multiple things in one. make a new feature request

closing this now

commented
  1. no... the home position is correct. the default home position will take the highest solid block in the middle of the claim. the value you highlighted in the file is also the z value and not y
  2. files do NOT save immediately and this is indented. io tasks are resource intensive and should only be done when needed. and in this case its done whenever the server saves
  3. see above

for the rest there is no need to make an issue for that... for the last one: dont make an issue containing multiple things in one. make a new feature request

closing this now

@Flemmli97 okey but the main Issue is not using the parent depth of the main claim,

All permissions are synced to the subclaim, but the depth option not, this is the main issue, what i had mentioned above.

Point 1 was not the Home position, its the issue, that it does not use the right depth on creating an subclaim.

The 2 point was the home position, and it does not save the home position in the subclaim.

It only save the home from an main position.

Had only mentioned on the home position, thats not the right heigh, but it is okey what you had said, but on the above informations, there are 2 bugs what you could and should look.

To the point 5, this are 3 times the same suggestion, to give the permission to transfere the subclaims to another people, if i add an new suggestion, it would be the 4th