🌷Floral Flair🌷

🌷Floral Flair🌷

980k Downloads

Floral Flair Configuration issues

LambdAurora opened this issue · 2 comments

commented

Hello! While attempting to make sure that my mod supports correctly this mod (flower pot shenanigans), I tried to use this mod in my dev env and something struck directly: it requires cloth config.

While, yes I could've paid more attention to the CurseForge description, the fact it crashes with a NoClassDefFoundError leads me to think dependencies are not properly managed in this mod (which the fabric.mod.json confirms).

So here are my remarks and suggestions:

  • add Cloth Config to your dependencies in the fabric.mod.json, while the error screen of the loader is not the greatest, it's always better than a hard to read crash!
  • I see that you haven't disabled 3rd party distribution on CurseForge, if that's intentional and you wish for your mod to be available for 3rd party distribution I would suggest to start Jar-in-Jar cloth config since it has disabled 3rd party distribution (meaning it indirectly affects this mod too).
  • The configuration is world-generation related, I would not recommend global configuration for world-generation and would prefer a data-pack approach instead. This would allow reloading (by restarting the logical server, better than restarting the game), and would allow configuration isolation easily; there's two ways at going about this:
    • use data-pack features fully and make the placedfeatures JSONs so they can be reconfigured at will with a separate data-pack and continue to use the BiomeModifications API to handle the additions
    • use a custom data-pack reader for configuration only, and keep the rest in-code, but that's way hackier as there's no APIs.
    • Those two ways might be less user-friendly on clients since there's no GUI anymore, that's a trade-off.

Have a great day!

commented

So this mod is being fully rewritten using the Pollen library so we can manage forge and fabric simultaneously, Pollen has a built in config system so Cloth Config will no longer be necessary.

Leaving 3rd party downloads on is completely intended, as turning them off would be a pain for anyone that would want to load the project using another launcher than the curseforge one.

And as for the last comment of going data driven that would probably be smart, will certainly look into that!

commented

Did not mean to close this