Flux Networks

Flux Networks

55M Downloads

Redstone dupping

TheoKah opened this issue ยท 10 comments

commented

Dropping redstone from the inventory (either with Q or moving it out with the mouse) spawns one in the world but also keep it in the inventory, resulting in a dupe.

video

using only:
forge-1.10.2-12.18.3.2202-universal.jar
spongeforge-1.10.2-2202-5.1.0-BETA-2020.jar
SonarCore-1.10.2-3.1.8.jar
FluxNetworks-1.10.2-1.0.8.jar

commented

Interesting. I was just looking at a similar dupe using via ae2, though I can't repro yours. It seems like the FluxEvents#onEntityAdded() handler is causing this somehow -- I'm suspicious that event.cancel() is putting the item back where it came from but then the entity is still being spawned.

commented

It is working as intented on singleplayer (no sponge) only have the problem on a server.

For some reason, there are 2 dropevents fired. Only the 2nd one is cancelled.

Why do you need to cancel this btw?

commented

I couldn't recreate this... wondering if another mod is clashing. What other mods do you have running? Perhaps I should add a backup way of getting Flux or change it completely maybe

commented

I tried with only the mods I listed:
forge-1.10.2-12.18.3.2202-universal.jar (not a 'mod' but meh)
spongeforge-1.10.2-2202-5.1.0-BETA-2020.jar
SonarCore-1.10.2-3.1.8.jar
FluxNetworks-1.10.2-1.0.8.jar

client is same (without sponge ofc)

commented

This happens with ae2, when ae2's formation plane drop redstone into the world, the event fired and canceled by flux networks to create a fire-proof version's item entity which caused formation plane thinks it didn't drop redstone but in reality a fire-proof redstone item entity will be spawned into the world.
Pictures: imgur link
Just my theory.
If this is the case, please consider a config option to switch to an alternative crafting method.
Sorry about my English.

commented

Whatever is done to the redstone, the drop event itself should not be canceled as the item is supposed to leave the inventory anyways. This is the item spawn event that should be tampered with in that case imo.

commented

This issue has been resolved in latest SpongeForge.

commented

Nice, I'll try it as soon as it is released. Last build was before your commit.

commented

@TheoKah SF 2078+ should have the fix.

commented

@SonarSonic please close this ticket as it has been resolved in SpongeForge.