Flux Networks

Flux Networks

Mods
55M Downloads

Difference between configuration and actual values.

MrChuw opened this issue ยท 2 comments

commented

Describe the bug
A clear and concise description of what the bug is and Flux Networks version.

In the configurations, the value you can set is configured for Long.MAX_VALUE, but the limits on plugs, points, etc., are hardcoded to Integer.MAX_VALUE. Could you please change the limits to Long.MAX_VALUE?

https://github.com/SonarSonic/Flux-Networks/blob/58add706e1ce49d53afe3eaef36e7d7cfe463c1b/src/main/java/sonar/fluxnetworks/FluxConfig.java#L209C13-L237C27

https://github.com/SonarSonic/Flux-Networks/blob/3815f7995b20dc44d149ebce1126ff52823d6a9f/src/main/java/sonar/fluxnetworks/api/energy/FNEnergyStorage.java#L86C5-L104C6

commented

The Forge Energy API has a limitation of Integer.MAX, whether or not there is a hardcoded Integer.MAX, the transfer limit will not exceed Integer.MAX. Didn't you see that this method returns an int. Only mods that implement Flux Energy API can have Long.MAX limit.

commented

Sorry, I didn't know about the Forge API, and since I don't know Java I didn't pay much attention, but it would be interesting to put a warning in the settings.