Flywheel (Legacy)

Flywheel (Legacy)

41M Downloads

Trying to upload an empty model during instancing causes a VBO upload failure

marchermans opened this issue ยท 0 comments

commented

Describe the Bug

When passing a model that has no vertices to the instancer to use as an instanced model, the upload process of that model crashes.

Reproduction Steps

  1. Create a baked model that has no quads:
    @NotNull
    @Override
    public List<BakedQuad> getQuads(@Nullable final BlockState state, @Nullable final Direction side, @NotNull final RandomSource rand)
    {
        return Collections.emptyList();
    }

Is a good example
2. Pass this model as a BlockModel to the instancer via for example an ActorInstance in create
3. Notice that the upload fails because no mapped memory region of size 0 can be allocated for the VBO

Expected Result

Either the Instancer should just skip upload and rendering, or not fail to upload.

Screenshots and Videos

No response

Crash Report or Log

https://gist.github.com/marchermans/6f91cfff448672fede9e48bc2cce721a

Operating System

Windows 11

What is your GPU?

NVidea Geforce RTX 2070 Super Max-Q

Mod Version

0.6.8

Minecraft Version

1.19.2

Loader Version

Forge 43.1.x

Other Mods

Create and Chisels And Bits

Additional Context

No response