Flywheel (Legacy)

Flywheel (Legacy)

Mods
43M Downloads

Vanillin: Item entity visual would keep rendering on screen even its not visible

MoePus opened this issue ยท 0 comments

commented

Spawn an item entity on player's face
As long as player's camera dont move, the item entity would keep rendering with the same position and rotation (method animate is not called)

Image

The red thing is redstone item entity took from the simple drawer, it would keep rendering on screen.

I think because in beginFrame, the item visual would not update its position if this item entity is not visible

@@ -50,10 +50,12 @@ public class ItemVisual extends AbstractEntityVisual<ItemEntity> implements Simp
 	}
 
 	@Override
 	public void beginFrame(Context ctx) {
 		if (!isVisible(ctx.frustum())) {
+			instances.resetCount();
+			instances.discardExtra();
 			return;
 		}
 
 		animate(ctx.partialTick());
 	}

This patch would fix this issue


Create:
	Mod Version: 6.0.6
	Mod Git Commit: 3afd91cf82471a66c160da9e12f5f5258378224a-modified
	Ponder Version: 1.0.56
	NeoForge Version: 21.1.193
	Minecraft Version: 1.21.1

Graphics:
	Flywheel Version: 1.0.4
	Flywheel Backend: flywheel:indirect
	OpenGL Renderer: NVIDIA GeForce RTX 4080/PCIe/SSE2
	OpenGL Version: 4.6.0 NVIDIA 572.16
	Graphics Mode: fancy
	PojavLauncher Detected: false

System Information:
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 21.0.7, Microsoft
	JVM Flags: 4 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx4096m -Xms256m
	Memory: 331088536 bytes (315 MiB) / 1027604480 bytes (980 MiB) up to 4294967296 bytes (4096 MiB)
	Total Memory: 703063744 bytes (670 MiB) / 1027604480 bytes (980 MiB)
	CPU: 13th Gen Intel(R) Core(TM) i9-13900KF @ 2.92 GHz; 24 cores / 24 threads on 1 socket(s)
	Graphics cards: none

Other Mods:
	EMI: 1.1.22+1.21.1+neoforge
	Iris: 1.8.12-snapshot+mc1.21.1-local
	Forgified Fabric Renderer API (v1): 3.4.0+acb05a3919
	Forgified Fabric API Base: 0.4.42+d1308ded19
	Create: Storage: 1.1.2
	Forgified Fabric Rendering Data Attachment (v1): 0.3.48+73761d2e19
	Sodium: 0.6.13+mc1.21.1
	Vanillin: 1.1.3
	Forgified Fabric BlockView API (v2): 1.0.10+9afaaf8c19

Create: Storage is the drawer mod.