Ability to control Spectral Vision trough configs or NBT.
NiyahVE opened this issue · 5 comments
Is your feature request related to a problem? Please describe.
It is related to this problem: EliteScouter/EliteHolograms#2 (comment)
Basically, Spectral Vision apply for invisible entities that we are not supposed to see and can't be cancelled.
Describe the solution you'd like
One of the two:
- Blacklist armor stands from the Spectral Eye effect entirely
- Add a config option to exclude specific entity types or NBT-tagged entities from the effect
Describe alternatives you've considered
Asked the EliteHolograms dev to take a look, didn't work sadly, no other mods are available for 1.21.1 for this.
Additional context
I'm playing with friends in a server with ATM10, they have " Infusion pylon" from https://github.com/jeremiahwinsley/pylons that permanently apply Spectral vision as an effect and it's really neat, but it ruins the Holograms because they are using Armor stands for them, anyways to bandaids fix this maybe ? The NBT-tagged route seem to be the best ways for my understanding for cross-mods compatibility without much hassle :)
Cheers !
After digging a little bit, I believe that the effect is applied client-side in a mixin here:
; I suppose that changing it to this might work:
if (this.player != null && this.player.hasEffect(ModMobEffects.SPECTRAL_VISION)) {
if (!entity.getPersistentData().getBoolean("PreventSpectralVision")) {
callback.setReturnValue(true);
}
}
However I can't give it a try right now, I have no JDK nor Dev environnement & it would be breaking your license as far as I understand.
I don't really like the idea of having a nbt tag for it but I could add a new entity tag (something like spectral_eye_unaffected). Would that be sufficient for you?
That would work.
I don't really like the idea of having a nbt tag for it but I could add a new entity tag (something like spectral_eye_unaffected). Would that be sufficient for you?
