
[Bug]: Force Liquid Regen - Does not heal player at low levels
4tw0ne opened this issue ยท 0 comments
General Info
- I am running a modpack
- I can reproduce this issue consistently in single-player
- I can reproduce this issue consistently in multi-player
- I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I am having the same problem.
- I am crashing and can provide my crash report(s)
- I am using the latest version of the mod
Forge version
43.3.0
Minecraft version
1.19.2
Mod version
3.3.4
Java version
Eclipse Adoptium/jre-17.0.12.7-hotspot
Issue Description
Issue:
When standing in flowing Force Liquid, Regen is applied to the player repeatedly preventing the effect from healing the player.
The hearts will 'bump' like the effect is applied, but no healing occurs.
At sufficiently high levels of Regen (ex. Level 4), healing is applied more often than every 10 ticks.
Discovered Mechanics:
Vanilla regen requires its Effect Time to count down for healing to process.
The amount of ticks required to pass also varies depending on the strength of Regen itself.
Regen 1 will only heal if 50 ticks of the Effect Time have passed.
Regen 2 is 25 ticks, Regen 3 is 12 ticks ...Seems to half each time the level is increased.
Suggestion for a fix is two parts:
- If the player has the Regen Effect, do not reapply the effect.
- Increase the tick amount of Regen from 10 to 50.
Context:
I discovered this while developing a Modpack. Although, this still occurs in an isolated instance with only ForceCraft installed.
50 Ticks was chosen as lowering the tick amount relative to the Regen Level did not seem to produce different healing results.
If Regen is applied with this increased tick rate, it will only work if the player gets in and out of the flowing liquid repeatedly; hence the need to not reapply the effect when already active.
Additional Information
No response